Skip to content

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Oct 14, 2021

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 14, 2021
@netlify
Copy link

netlify bot commented Oct 14, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 15adcc4

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/616837fe02564b0007698a8d

😎 Browse the preview: https://deploy-preview-37532--osdocs.netlify.app

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Oct 14, 2021

@yaoli-redhat This is the same content as you already reviewed in #36040, but changed batch/v1 to batch/v1beta1 for the cron job definition.

Can you please verify that v1beta1 is correct both here for 4.7 and also for 4.6 (done in #37533). Thanks!

Preview: https://deploy-preview-37532--osdocs.netlify.app/openshift-enterprise/latest/authentication/ldap-syncing.html#ldap-auto-syncing_ldap-syncing-groups

@yaoli-redhat
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@bergerhoffer bergerhoffer merged commit e8dfedc into openshift:enterprise-4.7 Oct 21, 2021
@bergerhoffer bergerhoffer deleted the pr-36040-cp-47 branch August 2, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants