Skip to content

[WIP] OSSMDOC-385: Jaeger 1.26 release notes and product name change #38557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] OSSMDOC-385: Jaeger 1.26 release notes and product name change #38557

wants to merge 1 commit into from

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Nov 10, 2021 •
edited
Loading

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2021
@netlify
Copy link

netlify bot commented Nov 10, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 14026b5

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/618da4f13793f600078b3792

😎 Browse the preview: https://deploy-preview-38557--osdocs.netlify.app

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2021
@rh-tokeefe rh-tokeefe force-pushed the OSSMDOC-385 branch 3 times, most recently from b6e416b to 8204a3d Compare November 10, 2021 20:51
@pavolloffay
Copy link
Member

Screenshot of Distributed tracing platform architecture - Distributed tracing platform architecture _ Distributed Tracing _ OpenShift Container Platfo

  • Jaeger node in the left menu should be removed. The Distributed Tracing substitutes it.
  • the submenus of Distributed Tracing are too long e.g. Distributed Tracing platform architecture perhaps we can call it just `Platform architecture (and rename other analogically) - this is just a suggestion, it might stay as it is, if it is hard to rename

Screenshot of Distributed tracing release notes _ Distributed Tracing _ OpenShift Container Platform Branch Build

The product name is Red Hat OpenShit distributed tracing and the current releasing version is 2.0

@mwringe
Copy link

mwringe commented Nov 11, 2021

Since we are changing the name from 'Jaeger' to 'Red Hat OpenShift distributed tracing', do you think it could make sense to highlight this fact at the very top of the release notes? So that people who may have been used to seeing 'Jaeger' understand this change?

mwringe
mwringe reviewed Nov 11, 2021
View reviewed changes
modules/distributed-tracing-rn-technology-preview.adoc Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OpenTelemetry collector has some capabilities beyond just tracing, we may want to highlight that only the tracing parts should be used at this point.

Perhaps something like:

"Red Hat OpenShift distributed tracing data collection is based on OpenTelemetry's operator and collector. The collector can be used to receive traces in either the OpenTelemetry or Jaeger protocol and send the trace data to the OpenShift distributed tracing platform. Other capabilities of the collector are not supported at this time."

@pavolloffay any thoughts on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OpenTelemetry collector has some capabilities beyond just tracing, we may want to highlight that only the tracing parts should be used at this point.

agree, we don't want people to prevent of using them, but we should mention this is not supported in our product

@rh-tokeefe rh-tokeefe force-pushed the OSSMDOC-385 branch 7 times, most recently from f92aab6 to a4294e5 Compare November 11, 2021 23:02
@JStickler JStickler added the service-mesh Label for all Service Mesh PRs label Nov 16, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2021

@rh-tokeefe: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rh-tokeefe
Copy link
Contributor Author

This PR is not needed. It was an early draft. Julie took over the project and submitted a different PR.

@rh-tokeefe rh-tokeefe closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mwringe mwringe mwringe left review comments

@pavolloffay pavolloffay pavolloffay left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. service-mesh Label for all Service Mesh PRs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rh-tokeefe @pavolloffay @mwringe @JStickler