Skip to content

RHDEVDOCS-3283 Document advanced prunning options #40748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2022
Merged

RHDEVDOCS-3283 Document advanced prunning options #40748

merged 1 commit into from
Mar 2, 2022

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Jan 19, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2022
@netlify
Copy link

netlify bot commented Jan 19, 2022 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 4a97e36

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/621f51d851e5ff00077e59c9

😎 Browse the preview: https://deploy-preview-40748--osdocs.netlify.app

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2022
pradeepitm12
pradeepitm12 reviewed Mar 1, 2022
View reviewed changes
@pradeepitm12
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
rolfedh
rolfedh reviewed Mar 1, 2022
View reviewed changes
rolfedh
rolfedh reviewed Mar 1, 2022
View reviewed changes
rolfedh
rolfedh reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Souvik. I left some suggestions and highlighted the new requirements for Jupiter.

@Preeticp Preeticp added branch/enterprise-4.9 branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Mar 2, 2022
@Preeticp Preeticp added this to the Next Release milestone Mar 2, 2022
RHDEVDOCS-3283 Document advanced prunning options
4a97e36 
deleted dummy module

full draft

fixed topic map

minor edits

SME review modifications

fixing attribute file paths

Peer review comments

modified based on Preeti's final comments
@Preeticp Preeticp added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022
@Preeticp Preeticp merged commit 37f81ee into openshift:main Mar 2, 2022
@Preeticp
Copy link
Contributor

Preeticp commented Mar 2, 2022

/cherrypick enterprise-4.9

@Preeticp
Copy link
Contributor

Preeticp commented Mar 2, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 2, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #42638

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 2, 2022
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #42639

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

@rolfedh rolfedh rolfedh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pradeepitm12 pradeepitm12

Labels

branch/enterprise-4.9 branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@sounix000 @pradeepitm12 @Preeticp @openshift-cherrypick-robot @rolfedh