Skip to content

Conversation

sabrinajess
Copy link
Contributor

@sabrinajess sabrinajess commented Feb 2, 2022

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 2, 2022
@sabrinajess sabrinajess changed the base branch from main to enterprise-4.10 February 2, 2022 18:10
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 2, 2022
@netlify
Copy link

netlify bot commented Feb 2, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 46bf822

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61faf1488da85900077ecff8

😎 Browse the preview: https://deploy-preview-41303--osdocs.netlify.app/openshift-enterprise/latest/virt/virt-4-10-release-notes

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2022
@kbidarkar
Copy link

kbidarkar commented Feb 2, 2022

LGTM

@ousleyp
Copy link
Member

ousleyp commented Feb 2, 2022

This looks great to me. The only thing I would suggest is adding a bullet point to separate the workaround section from the rest (see the other Known Issues for examples). Thanks!

@ousleyp ousleyp added CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 2, 2022
@ousleyp ousleyp added this to the Future Release milestone Feb 2, 2022
@ousleyp ousleyp merged commit 87c0f9c into openshift:enterprise-4.10 Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants