Skip to content

Conversation

kalexand-rh
Copy link
Contributor

@kalexand-rh kalexand-rh commented Feb 3, 2022

Adding guidance to the contributors guidelines about the emerging use of content type attributes.

Preview: https://github.com/openshift/openshift-docs/blob/7d7340e056f632c630b2f61504ff7f935d569454/contributing_to_docs/doc_guidelines.adoc#content-type-attributes

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2022
@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 58d4b99

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61fbfb6338dacc00081afddc

😎 Browse the preview: https://deploy-preview-41331--osdocs.netlify.app

@jeana-redhat jeana-redhat added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2022
Copy link
Contributor

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahardin-rh
Copy link
Contributor

Looks great!

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2022
@kalexand-rh kalexand-rh merged commit fceecfb into openshift:main Feb 3, 2022
@kalexand-rh kalexand-rh deleted the type-attributes branch February 3, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants