Skip to content

OSDOCS-2932: OSDK-1760: digest bundle for disconnected environments #42315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2022
Merged

OSDOCS-2932: OSDK-1760: digest bundle for disconnected environments #42315

merged 1 commit into from
Mar 4, 2022

Conversation

michaelryanpeter
Copy link
Contributor

@michaelryanpeter michaelryanpeter commented Feb 23, 2022 •
edited
Loading

Docs preview links:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 23, 2022
@netlify
Copy link

netlify bot commented Feb 23, 2022 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: ad49d8d

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/622230d5c026f30008c948a1

😎 Browse the preview: https://deploy-preview-42315--osdocs.netlify.app/openshift-enterprise/latest/operators/operator_sdk/osdk-generating-csvs

@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2932-osdk-sha-digest-bundle branch 2 times, most recently from 1fc32ad to 41e7539 Compare February 23, 2022 20:22
@michaelryanpeter michaelryanpeter changed the title OSDOCS-2932: OSDK-1760: digest bundle for disconnected environments [WIP] OSDOCS-2932: OSDK-1760: digest bundle for disconnected environments Feb 23, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2022
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2932-osdk-sha-digest-bundle branch 2 times, most recently from b92a1ca to 482db89 Compare February 25, 2022 17:27
@michaelryanpeter michaelryanpeter changed the title [WIP] OSDOCS-2932: OSDK-1760: digest bundle for disconnected environments OSDOCS-2932: OSDK-1760: digest bundle for disconnected environments Feb 25, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2022
@michaelryanpeter michaelryanpeter added branch/enterprise-4.10 peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 25, 2022
@michaelryanpeter michaelryanpeter added this to the Future Release milestone Feb 25, 2022
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2932-osdk-sha-digest-bundle branch 8 times, most recently from 3d5fbae to 2909c8d Compare February 25, 2022 22:11
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2022
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2932-osdk-sha-digest-bundle branch 3 times, most recently from a78e1ca to 533913e Compare February 27, 2022 17:47
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2022
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2932-osdk-sha-digest-bundle branch from 533913e to f66d4cf Compare February 27, 2022 18:24
@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2022

@ryantking: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelryanpeter
Copy link
Contributor Author

@emmajiafan Would you PTAL?

@emmajiafan
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
opayne1
opayne1 reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments that I think are mostly just clarity suggestions. :)

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 3, 2022
kalexand-rh
kalexand-rh reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions and requests, which mostly back up what Olivia is saying.

@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2932-osdk-sha-digest-bundle branch from 5a1c0b8 to 3fbff54 Compare March 3, 2022 19:22
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2932-osdk-sha-digest-bundle branch 3 times, most recently from 2fd221c to c5675d1 Compare March 3, 2022 20:20
kalexand-rh
kalexand-rh reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few picky things, but this is looking good!

@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2932-osdk-sha-digest-bundle branch 2 times, most recently from 79e5936 to 709d1f5 Compare March 3, 2022 21:37
jmrodri
jmrodri approved these changes Mar 3, 2022
View reviewed changes
Copy link

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2932-osdk-sha-digest-bundle branch from 709d1f5 to ad49d8d Compare March 4, 2022 15:31
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 4, 2022

New changes are detected. LGTM label has been removed.

@michaelryanpeter michaelryanpeter merged commit d81e867 into openshift:main Mar 4, 2022
@michaelryanpeter
Copy link
Contributor Author

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2022
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #42825

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru modified the milestones: Future Release, OCP 4.10 GA Mar 10, 2022
@michaelryanpeter michaelryanpeter deleted the OSDOCS-2932-osdk-sha-digest-bundle branch October 26, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

@opayne1 opayne1 opayne1 left review comments

+4 more reviewers

@emmajiafan emmajiafan emmajiafan left review comments

@ryantking ryantking ryantking requested changes

@jmrodri jmrodri jmrodri approved these changes

@theishshah theishshah theishshah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmrodri jmrodri

@emmajiafan emmajiafan

Labels

branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.10 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@michaelryanpeter @emmajiafan @ryantking @openshift-cherrypick-robot @jmrodri @theishshah @kalexand-rh @opayne1 @bobfuru