Skip to content

Conversation

jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Mar 2, 2022

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2022
@netlify
Copy link

netlify bot commented Mar 2, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: d15d60b

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/62221c1ce5efbd0008f25b0c

😎 Browse the preview: https://deploy-preview-42685--osdocs.netlify.app

@jeana-redhat jeana-redhat force-pushed the RN_OSDOCS-2329_GCP_workload_identity branch from ff4d0fe to c7063a5 Compare March 2, 2022 19:24
@jeana-redhat jeana-redhat added this to the Future Release milestone Mar 2, 2022
@jeana-redhat jeana-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 3, 2022
@jeana-redhat jeana-redhat force-pushed the RN_OSDOCS-2329_GCP_workload_identity branch from c7063a5 to 293ca90 Compare March 3, 2022 13:29
@jeana-redhat
Copy link
Contributor Author

@jianping-shu - not much to verify here, but could you please give it a look?

Copy link

@akhil-rane akhil-rane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR labels Mar 3, 2022
@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 3, 2022
@jianping-shu
Copy link

/lgtm

@jeana-redhat jeana-redhat force-pushed the RN_OSDOCS-2329_GCP_workload_identity branch from 293ca90 to d15d60b Compare March 4, 2022 14:03
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 4, 2022

New changes are detected. LGTM label has been removed.

@jeana-redhat
Copy link
Contributor Author

Force pushed to force rebuild before merging, no change.

@jeana-redhat jeana-redhat merged commit f1b4c14 into openshift:enterprise-4.10 Mar 4, 2022
@bobfuru bobfuru modified the milestones: Future Release, OCP 4.10 GA Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants