Skip to content

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Apr 1, 2022

Per Slack conversation.

https://docs.openshift.com/container-platform/4.9/windows_containers/windows-containers-release-notes-4-x.html#getting-support is confusing,... I thus recommend fixing docs and pointing to https://access.redhat.com/support/policy/updates/openshift#windows `

Previews:
Getting support
OKD without the Getting support section.

Changing 4.6 to 4.9 in separate PRs, as this section is in the release notes and only in that branch.

@mburke5678 mburke5678 added this to the Next Release milestone Apr 1, 2022
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2022
@mburke5678
Copy link
Contributor Author

@Anandnatraj @sreber84 @mtnbikenc PTAL

@netlify
Copy link

netlify bot commented Apr 1, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 7331460
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/624c937b676f90000862f4c9
😎 Deploy Preview https://deploy-preview-44112--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except there appears to be a missing colon.


You must have this separate subscription to receive support for the Red Hat WMCO. Deploying Windows container workloads in production clusters is not supported without this separate subscription. You can request support through the link:http://access.redhat.com/[Red Hat Customer Portal].

For more information, see the Red Hat OpenShift Container Platform Life Cycle Policy document for linkhttps://access.redhat.com/support/policy/updates/openshift#windows[OpenShift Container Platform for Windows Containers].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information, see the Red Hat OpenShift Container Platform Life Cycle Policy document for linkhttps://access.redhat.com/support/policy/updates/openshift#windows[OpenShift Container Platform for Windows Containers].
For more information, see the Red Hat OpenShift Container Platform Life Cycle Policy document for link:https://access.redhat.com/support/policy/updates/openshift#windows[OpenShift Container Platform for Windows Containers].

@Anandnatraj
Copy link

Please make the following changes

Windows Container Support for Red Hat OpenShift is provided and available as an optional, installable component. Windows Container Support for Red Hat OpenShift is not part of the OpenShift Container Platform subscription, it requires an additional Red Hat subscription and is supported per the Scope of coverage and Service level agreements.

From
Deploying Windows container workloads in production clusters is not supported without this separate subscription.
To
Without this separate subscription, deploying Windows container workloads in production clusters is not supported.

If you do not have this additional Red Hat subscription, you can use the community WMCO, a distribution that lacks official support.

@Anandnatraj
Copy link

I see mu changes above have been incorporated. Much thanks. LGTM

@mburke5678
Copy link
Contributor Author

@rrasouli Can you PTAL? Thank you!

@rrasouli
Copy link

rrasouli commented Apr 5, 2022

/lgtm thanks!

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2022
@mburke5678
Copy link
Contributor Author

@rrasouli Thank you for the quick review. However, we probably should remove this statement from the OKD docs. Can you take another quick look?
ddc5224

@rrasouli
Copy link

rrasouli commented Apr 5, 2022

@mburke5678 hey, I can't see the diff on the preview

@mburke5678
Copy link
Contributor Author

mburke5678 commented Apr 5, 2022

@rrasouli Please see #44201

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2022

@mburke5678: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2022
@mburke5678
Copy link
Contributor Author

Closing in favor of #44201

@mburke5678 mburke5678 closed this Apr 5, 2022
@mburke5678 mburke5678 deleted the winc-fix-support-statement branch September 14, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 branch/enterprise-4.11 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants