Skip to content

Conversation

sagidlow
Copy link
Contributor

@sagidlow sagidlow commented Apr 7, 2022

Applies to 4.6+
BZ Link: https://bugzilla.redhat.com/show_bug.cgi?id=1961399
QE ack required.
**Preview Link: ** Added a sentence before Table 3 in the Required GCP permissions section.

@sagidlow sagidlow added this to the Next Release milestone Apr 7, 2022
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2022
@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 6d9c48a
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/624f3e43b95e350009cac9cf
😎 Deploy Preview https://deploy-preview-44356--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022

The roles are applied to the service accounts that the control plane and compute
machines use:
machines use. The roles are required for configuring a GCP project to host the {product-title}.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial ask was to clarify "if the entries in the table is for Installer or after-install operations or both". I don't think the above statement answers the question, could you please clarify? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianli-wei Do you have any suggestions for the text? My understanding is that these roles are required to configure a GCP project which is done prior to installing OCP.

Copy link

@jianli-wei jianli-wei Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagidlow Sorry, it's not for configuring a GCP project, because the GCP projects (one as service project and another as host project) should have been created before OCP installation. As for the initial ask, i.e. "if the entries in the table is for Installer or after-install operations or both", sorry that I cannot answer for sure even after discussing with other QEs. We guess, the Day-1 and Day-2 operations may require the same set of roles, in terms of the control plane and compute machines. @patrickdillon Would you please advise? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I don't think the bug is valid. It says "As it is written now, it is not clear if the entries in the table is for Installer or after-install operations or both." The doc clearly states: " To deploy an {product-title} cluster, the service
account requires the following permissions."

So yes, it is a requirement for deployment. We have separate sections which also talk about permissions required to operate the cluster. I think https://bugzilla.redhat.com/show_bug.cgi?id=1961399 is NOTABUG

Asa a side note, when reviewing this, I noticed "The roles are applied to the service accounts that the control plane and compute machines use." This is not accurate. It could simply be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianli-wei, are you ok with us closing this issue as NOTABUG?

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2022
@sagidlow
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2022
@bergerhoffer
Copy link
Contributor

The enterprise-4.12 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.11. And any PR going into main must also target the latest version branch (enterprise-4.12).

If the update in your PR does NOT apply to version 4.12 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@kalexand-rh kalexand-rh removed the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 23, 2022
@kalexand-rh
Copy link
Contributor

Only versions 4.8+ are still in maintenance. I am removing labels from earlier versions from this PR.

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.13 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.12. And any PR going into main must also target the latest version branch (enterprise-4.13).

If the update in your PR does NOT apply to version 4.13 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@kalexand-rh
Copy link
Contributor

@jianli-wei, are you ok with us closing this issue as NOTABUG?

@jianli-wei
Copy link

@jianli-wei, are you ok with us closing this issue as NOTABUG?

Yes, please go ahead. FYI there's a 4.13 epic CORS-1871 Determine and Document the explicit list of required credential permissions for GCP which I think would clarify the required permissions for GCP. Thanks!

@kalexand-rh
Copy link
Contributor

@jianli-wei, are you ok with us closing this issue as NOTABUG?

Yes, please go ahead. FYI there's a 4.13 epic CORS-1871 Determine and Document the explicit list of required credential permissions for GCP which I think would clarify the required permissions for GCP. Thanks!

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants