Skip to content

RHDEVDOCS-3629 - Updating 4.6 EventRouter template to match 4.7+ #45297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

RHDEVDOCS-3629 - Updating 4.6 EventRouter template to match 4.7+ #45297

wants to merge 1 commit into from

Conversation

libander
Copy link
Contributor

@libander libander commented May 4, 2022 •
edited
Loading

Team: DevTools

Updated EventRouter template in 4.6 docs to match template in 4.7 - 4.10.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 4, 2022
@libander libander changed the title RHDEVDOCS-3629 - Updating 4.6 Eventrouter template to match 4.7+ RHDEVDOCS-3629 - Updating 4.6 EventRouter template to match 4.7+ May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit a081f87
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/62852e578d2de90008e05bb9
😎 Deploy Preview https://deploy-preview-45297--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

anpingli
anpingli reviewed May 6, 2022
View reviewed changes
Copy link

@anpingli anpingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Example output changed
[source,terminal]

serviceaccount/eventrouter created
clusterrole.authorization.openshift.io/event-reader created
clusterrolebinding.authorization.openshift.io/event-reader-binding created
configmap/eventrouter created
deployment.apps/eventrouter created

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2022
@libander libander requested a review from anpingli May 18, 2022 17:38
jc-berger
jc-berger approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 18, 2022

@jc-berger: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anpingli
Copy link

Must we use 0.3 in Openshift 4.6? We are still releasing 4.6 https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1995200

@Preeticp Preeticp added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.6 labels May 23, 2022
@libander
Copy link
Contributor Author

libander commented Jun 8, 2022

@anpingli - what tag should 4.6 specifically use instead?

@JStickler JStickler mentioned this pull request Jun 8, 2022
Merged
@anpingli
Copy link

I suggest using registry.redhat.io/openshift4/ose-logging-eventrouter:v4.6 in v4.6.

@anpingli
Copy link

I suggest using registry.redhat.io/openshift4/ose-logging-eventrouter:v4.6 in Openshift v4.6. @jcantrill WDYT?

@libander libander closed this Aug 19, 2022
@libander libander deleted the RHDEVDOCS-3629 branch May 2, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anpingli anpingli Awaiting requested review from anpingli

1 more reviewer

@jc-berger jc-berger jc-berger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.6 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@libander @anpingli @jc-berger @Preeticp