Skip to content

WIP OCPBUGS#9229: Graceful Shutdown improvements #45621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

WIP OCPBUGS#9229: Graceful Shutdown improvements #45621

wants to merge 2 commits into from

Conversation

nalhadef
Copy link
Contributor

@nalhadef nalhadef commented May 12, 2022 •
edited
Loading

Version(s):
Main and 4.6 and above

Issue:
Bug 2076315

Link to docs preview (Updated Sept. 8, 2023):
https://45621--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/graceful-cluster-shutdown#graceful-shutdown_graceful-shutdown-cluster

Additional information:

QE Reviewer: liqcui@redhat.com

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 12, 2022
@nalhadef nalhadef changed the title BZ2076315: Graceful Shutdown improvements WIP BZ2076315: Graceful Shutdown improvements May 12, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2022
@netlify
Copy link

netlify bot commented May 12, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 9874b62
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/627d3e527393560009a97c17
😎 Deploy Preview https://deploy-preview-45621--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nalhadef nalhadef force-pushed the bz2076315 branch 4 times, most recently from 44c3152 to 9874b62 Compare May 12, 2022 17:05
@sunilcio
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 16, 2022
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Oct 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2022

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh reopened this Dec 1, 2022
@kalexand-rh
Copy link
Contributor

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 1, 2022
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2023
@kalexand-rh
Copy link
Contributor

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 3, 2023
lyman9966
lyman9966 reviewed May 15, 2023
View reviewed changes
@kalexand-rh kalexand-rh changed the title WIP BZ2076315: Graceful Shutdown improvements WIP OCPBUGS-9229: Graceful Shutdown improvements Aug 4, 2023
@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Aug 4, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 4, 2023
@openshift-ci-robot
Copy link

@nalhadef: This pull request references Jira Issue OCPBUGS-9229, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.6.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
Main and 4.6 and above

Issue:
Bug 2076315

Link to docs preview:
https://deploy-preview-45621--osdocs.netlify.app/openshift-enterprise/latest/backup_and_restore/graceful-cluster-shutdown.html

Additional information:

QE Reviewer: liqcui@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh changed the title WIP OCPBUGS-9229: Graceful Shutdown improvements WIP OCPBUGS#9229: Graceful Shutdown improvements Aug 4, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 4, 2023
@openshift-ci-robot
Copy link

@nalhadef: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
Main and 4.6 and above

Issue:
Bug 2076315

Link to docs preview:
https://deploy-preview-45621--osdocs.netlify.app/openshift-enterprise/latest/backup_and_restore/graceful-cluster-shutdown.html

Additional information:

QE Reviewer: liqcui@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 24, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://45621--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/24925

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2023
@nalhadef
Copy link
Contributor Author

nalhadef commented Sep 8, 2023

Sent for QE review September 8, 2023.

lyman9966
lyman9966 reviewed Sep 11, 2023
View reviewed changes
@nalhadef nalhadef mentioned this pull request Sep 22, 2023
Merged
@kalexand-rh
Copy link
Contributor

Closing in favor of #65094.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lyman9966 lyman9966 lyman9966 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sunilcio sunilcio

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nalhadef @sunilcio @openshift-bot @kalexand-rh @openshift-ci-robot @ocpdocs-previewbot @lyman9966 @openshift-merge-robot