-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added a release note for AWS bootstrap logging during installation #45831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a release note for AWS bootstrap logging during installation #45831
Conversation
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@yunjiang29 Please review this release note for CORS-1906 on AWS. Thank you |
@bscott-rh lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about terms in the diff comments.
Re: your question about "4.11" vs "{product-version}" - a lot of times we don't even call the release out at all for these. For instance:
- "With this release,
<blah blah feature text>
" - "You can now
<blah blah feature text>
" - "
<feature>
now<does/supports whatever>
"
If you do want to call the version out, I think either approach is fine. Looking at the 4.10 rel notes, both are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking through that link, I see this is a place where we still seem to be subject to the use of "master" due to its use in the code. I also see that page uses "control plane, or master, machines" in many places. Would it work to use that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'm sure it would be OK to just say "control plane" in the release notes. We only start using master later on because it's a flag in the gather command, and the annotation explains it.
fa89bc1
to
6e828bc
Compare
6e828bc
to
6b5fc2d
Compare
Release note for https://issues.redhat.com/browse/CORS-1906
Doc preview