Skip to content

Conversation

bscott-rh
Copy link
Contributor

@bscott-rh bscott-rh commented May 18, 2022

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2022
@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 6b5fc2d
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/62865cad46bbaf00096dc051
😎 Deploy Preview https://deploy-preview-45831--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bscott-rh
Copy link
Contributor Author

bscott-rh commented May 18, 2022

@yunjiang29 Please review this release note for CORS-1906 on AWS. Thank you

@yunjiang29
Copy link
Contributor

@bscott-rh lgtm

Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about terms in the diff comments.

Re: your question about "4.11" vs "{product-version}" - a lot of times we don't even call the release out at all for these. For instance:

  • "With this release, <blah blah feature text>"
  • "You can now <blah blah feature text>"
  • "<feature> now <does/supports whatever>"

If you do want to call the version out, I think either approach is fine. Looking at the 4.10 rel notes, both are used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking through that link, I see this is a place where we still seem to be subject to the use of "master" due to its use in the code. I also see that page uses "control plane, or master, machines" in many places. Would it work to use that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'm sure it would be OK to just say "control plane" in the release notes. We only start using master later on because it's a flag in the gather command, and the annotation explains it.

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.11 labels May 19, 2022
@jeana-redhat jeana-redhat added this to the Future Release milestone May 19, 2022
@bscott-rh bscott-rh force-pushed the RN-AWS-serial-logs branch from fa89bc1 to 6e828bc Compare May 19, 2022 14:29
@bscott-rh bscott-rh force-pushed the RN-AWS-serial-logs branch from 6e828bc to 6b5fc2d Compare May 19, 2022 15:05
@jeana-redhat jeana-redhat merged commit 2b0aa0a into openshift:enterprise-4.11 May 19, 2022
@bscott-rh bscott-rh deleted the RN-AWS-serial-logs branch October 30, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants