Skip to content

OSDOCS-3633-RN enabling Azure DiskEncryptionSets #46413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

OSDOCS-3633-RN enabling Azure DiskEncryptionSets #46413

merged 1 commit into from
Jul 26, 2022

Conversation

bscott-rh
Copy link
Contributor

@bscott-rh bscott-rh commented Jun 6, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2022
@bscott-rh
Copy link
Contributor Author

@mgahagan73 @Amoghrd Hello Mike and Amogh, could one of you please take a look at this release note for CORS-1494? I will circle back and update the "Additional information" link with a valid URL once the main PR for the documentation is complete. Thank you

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2022

@bscott-rh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh bscott-rh force-pushed the OSDOCS-3633-RN branch 2 times, most recently from a9949a6 to 41decee Compare July 19, 2022 22:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2022
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2022
@mgahagan73
Copy link

Release not looks good, the additional info url still has no content though.

@bscott-rh
Copy link
Contributor Author

Release not looks good, the additional info url still has no content though.

Thanks Mike - the URL will be present once #45685 is merged. I will update this PR with the proper URL once that happens.

@bscott-rh bscott-rh force-pushed the OSDOCS-3633-RN branch 2 times, most recently from 972ca15 to c1ac04a Compare July 20, 2022 19:58
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2022
tmalove
tmalove reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@tmalove tmalove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@mburke5678 mburke5678 merged commit 0877f0c into openshift:enterprise-4.11 Jul 26, 2022
@bscott-rh bscott-rh deleted the OSDOCS-3633-RN branch October 30, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tmalove tmalove tmalove left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mburke5678 mburke5678

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bscott-rh @mgahagan73 @mburke5678 @tmalove @openshift-merge-robot