Skip to content

[WIP]Agent-249: disconnected install through Agent-based Installer #53132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP]Agent-249: disconnected install through Agent-based Installer #53132

wants to merge 1 commit into from

Conversation

Amrita42
Copy link
Contributor

@Amrita42 Amrita42 commented Nov 23, 2022 •
edited
Loading

  • Applies to main and 4.12
  • Jira
  • Preview
  • Questions
  • Do we want to mention the optional subcommand to create clusters?
  • Is there a sample ca-bundle.crt file i should add ?
  • Also is there anything I have missed?
  • Please provide a tech review for the pre-reqs/procedure.

@bfournie ptal

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 23, 2022 •
edited
Loading

🤖 Updated build preview is available at:
https://53132--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/4145

@Amrita42 Amrita42 changed the title Agent-249: disconnected install through Agent-based Installer [WIP]Agent-249: disconnected install through Agent-based Installer Nov 23, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2022
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2022
@Amrita42 Amrita42 force-pushed the Agent-249 branch 2 times, most recently from 69995fc to 1d987a9 Compare November 28, 2022 13:00
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2022
@Amrita42 Amrita42 force-pushed the Agent-249 branch 2 times, most recently from 1f4ef9c to 9b021c1 Compare November 28, 2022 13:33
bfournie
bfournie reviewed Nov 28, 2022
View reviewed changes
...installing_with_agent_based_installer/understanding-disconnected-installation-mirroring.adoc Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the statement "ensure that your clusters only use container images that satisfy your organizational controls on external content" is correct, as the container images started out external, they were just mirrored and stored locally. Does that mean they are no longer "external" content?

modules/agent-install-mirroring-for-disconnected-registry.adoc Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the alternate way of mirroring using the oc mirror command should be documented in a separate section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referencing https://docs.openshift.com/container-platform/4.11/installing/disconnected_install/index.html
In that, we have two methods
oc adm
oc mirror

https://docs.openshift.com/container-platform/4.11/installing/disconnected_install/installing-mirroring-installation-images.html >> step v is the above command, is that wrong?

modules/agent-install-mirroring-for-disconnected-registry.adoc Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only necessary if mirroring to removable media.

modules/agent-install-mirroring-for-disconnected-registry.adoc Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again this is a separate step independent of the first step, it should be specified like that.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@Amrita42
Copy link
Contributor Author

Amrita42 commented Dec 2, 2022

I am closing this PR due to build failure, also potential merge conflicts.

Opened a new PR with some feedback implemented. #53404

@Amrita42 Amrita42 closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bfournie bfournie bfournie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Amrita42 @ocpdocs-previewbot @bfournie @openshift-merge-robot