SPLAT-767: permission validation now works for vsphere #54590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XS
|
@jinyunma, will you PTAL? |
|
🤖 Build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/6844 |
|
@kalexand-rh thanks for addressing this, the update looks good to me. |
kalexand-rh
added
the
peer-review-needed
|
Thank you so much! |
mburke5678
added
peer-review-done
|
/lgtm |
|
/cherrypick enterprise-4.12 |
|
@kalexand-rh: new pull request created: #54653 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s):
4.12
Issue:
https://issues.redhat.com/browse/SPLAT-767
Link to docs preview:
Because of the conditional statements, this change will appear in multiple vSphere topics, but this one is representative.
QE review: