Skip to content

OSDOCS#5227: RN for three-node cluster support on public cloud and vSphere #56307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

OSDOCS#5227: RN for three-node cluster support on public cloud and vSphere #56307

merged 1 commit into from
Mar 17, 2023

Conversation

mjpytlak
Copy link
Contributor

@mjpytlak mjpytlak commented Feb 22, 2023 •
edited
Loading

Version(s):
4.13

Issue:
This PR address osdocs-5227. This Jira issue represents the collective docs work for three-node support on AWS, Azure, GCP, and vSphere.

Link to docs preview:

Three-node cluster support

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 22, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://56307--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11416

@mjpytlak mjpytlak added this to the Planned for 4.13 GA milestone Feb 22, 2023
@mjpytlak
Copy link
Contributor Author

@shaozha @WenXinWei @jinyunma @jianli-wei There is going to be an early drop of the 4.13 release notes soon. Given that I am using one RN to announce support across platforms, wanted to include QE from all of the supported platforms PTAL.

FYI: AWS draft doc is currently in review. Once approved, doc for the remaining supported platforms will follow.

jianli-wei
jianli-wei suggested changes Feb 23, 2023
View reviewed changes
release_notes/ocp-4-13-release-notes.adoc Outdated
[id="ocp-4-13-installation-and-upgrade-three-node"]
==== Three-node cluster support

Beginning with {product-title} 4.12, deploying a three-node cluster is supported on Amazon Web Services(AWs), Google Cloud Platform (GCP), Microsoft Azure, and VMware vSphere. This type of {product-title} cluster is a smaller, more resource efficient cluster, as it consists of zero compute machines and three control plane machines only.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about replacing as it consists of zero compute machines and three control plane machines only with as it only consists of three control plane machines, which also act as compute machines? Because it's not really zero compute machines, but the 3 machines acting as both compute and control plane machines. Thanks!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, actually, three nodes have both "master" and "worker" roles.

NAME                                                          STATUS   ROLES                               AGE    VERSION           INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                                                        KERNEL-VERSION                 CONTAINER-RUNTIME
ci-op-rbqqvr7j-77520-5flbs-master-0.c.XXXXXXXXXXXX.internal   Ready    control-plane,master,worker   6h7m   v1.26.0+b923723   10.0.0.5      <none>        Red Hat Enterprise Linux CoreOS 413.86.202302201445-0 (Ootpa)   4.18.0-372.43.1.el8_6.x86_64   cri-o://1.26.1-6.rhaos4.13.git159cc9c.el8
ci-op-rbqqvr7j-77520-5flbs-master-1.c.XXXXXXXXXXXX.internal   Ready    control-plane,master,worker   6h7m   v1.26.0+b923723   10.0.0.4      <none>        Red Hat Enterprise Linux CoreOS 413.86.202302201445-0 (Ootpa)   4.18.0-372.43.1.el8_6.x86_64   cri-o://1.26.1-6.rhaos4.13.git159cc9c.el8
ci-op-rbqqvr7j-77520-5flbs-master-2.c.XXXXXXXXXXXX.internal   Ready    control-plane,master,worker   6h6m   v1.26.0+b923723   10.0.0.3      <none>        Red Hat Enterprise Linux CoreOS 413.86.202302201445-0 (Ootpa)   4.18.0-372.43.1.el8_6.x86_64   cri-o://1.26.1-6.rhaos4.13.git159cc9c.el8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about replacing as it consists of zero compute machines and three control plane machines only with as it only consists of three control plane machines, which also act as compute machines?

@jianli-wei @jinyunma Excellent point. Updated accordingly. Thank you.

@mjpytlak
Copy link
Contributor Author

mjpytlak commented Mar 10, 2023 •
edited
Loading

@shaozha @WenXinWei @jinyunma @jianli-wei Thanks to everyone for their input on the three-node cluster docs. Please take a moment to review the release note. An early copy of the RN is going to stakeholders on March 14th. If possible, I would like to have this in that version.

@jianli-wei
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@jinyunma
Copy link

/lgtm

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2023
@shaozha
Copy link

shaozha commented Mar 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@WenXinWei
Copy link

/lgtm

@mjpytlak mjpytlak added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 17, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2023

New changes are detected. LGTM label has been removed.

@lahinson
Copy link
Contributor

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 17, 2023
lahinson
lahinson reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a couple of tiny things, but otherwise, LGTM!

release_notes/ocp-4-13-release-notes.adoc Outdated
[id="ocp-4-13-installation-and-upgrade-three-node"]
==== Three-node cluster support

Beginning with {product-title} {product-version}, deploying a three-node cluster is supported on Amazon Web Services(AWs), Microsoft Azure, Google Cloud Platform (GCP), and VMware vSphere. This type of {product-title} cluster is a smaller, more resource efficient cluster, as it only consists of three control plane machines, which also act as compute machines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Beginning with {product-title} {product-version}, deploying a three-node cluster is supported on Amazon Web Services(AWs), Microsoft Azure, Google Cloud Platform (GCP), and VMware vSphere. This type of {product-title} cluster is a smaller, more resource efficient cluster, as it only consists of three control plane machines, which also act as compute machines.
Beginning with {product-title} {product-version}, deploying a three-node cluster is supported on Amazon Web Services (AWS), Microsoft Azure, Google Cloud Platform (GCP), and VMware vSphere. This type of {product-title} cluster is a smaller, more resource efficient cluster, as it consists of only three control plane machines, which also act as compute machines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right @lahinson. The variable is replaced with 4.13 when it goes live. Thanks for the review.

@lahinson
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 17, 2023
@mjpytlak mjpytlak force-pushed the osdocs-5227-rn branch 2 times, most recently from a189298 to d671176 Compare March 17, 2023 18:13
@mjpytlak mjpytlak merged commit e219a30 into openshift:enterprise-4.13 Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahinson lahinson lahinson left review comments

+2 more reviewers

@jinyunma jinyunma jinyunma left review comments

@jianli-wei jianli-wei jianli-wei requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jinyunma jinyunma

@jianli-wei jianli-wei

@WenXinWei WenXinWei

@shaozha shaozha

Labels

branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

4.13 GA

Development

Successfully merging this pull request may close these issues.

7 participants

@mjpytlak @ocpdocs-previewbot @jianli-wei @jinyunma @shaozha @WenXinWei @lahinson