Skip to content

OSDOCS-5196-4-12: Updated vSphere versioning format for 4.12 docs #56324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

OSDOCS-5196-4-12: Updated vSphere versioning format for 4.12 docs #56324

merged 1 commit into from
Feb 28, 2023

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Feb 22, 2023 •
edited
Loading

Issue:
OSDOCS-5196

Version(s):
4.12

Link to docs preview:

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2023
@ocpdocs-previewbot
Copy link

🤖 Build preview is available at:
https://56324--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/9533

@rvanderp3
Copy link
Contributor

LGTM
cc: @jcpowermac

@duanwei33
Copy link

/lgtm
cc @sgaoshang

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 28, 2023
@kcarmichael08
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 28, 2023
kcarmichael08
kcarmichael08 reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like QE reviewed and approved so please check the box for that on the PR body. Otherwise, LGTM!

@kcarmichael08
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 28, 2023
@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 28, 2023
@mburke5678 mburke5678 merged commit 023c6df into openshift:enterprise-4.12 Feb 28, 2023
@kalexand-rh kalexand-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

Assignees

@duanwei33 duanwei33

Labels

lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dfitzmau @ocpdocs-previewbot @rvanderp3 @duanwei33 @kcarmichael08 @mburke5678 @kalexand-rh