-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#5665: Adding steps to migrate clusters to multi-arch cli #58104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14152 |
3e43f82
to
9af01c5
Compare
/cc |
d2470ce
to
6cc0ea7
Compare
cc @aleskandro for review from multi-arch side. Thank you! |
few important notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some stuff with multi-arch in mind. Looks great!
62583de
to
cf2d738
Compare
03440f3
to
f962f2f
Compare
c39f10d
to
be7b66e
Compare
/label peer-review-needed |
f075c9e
to
52da7eb
Compare
/label qe-approved |
7906fcd
to
472d88b
Compare
472d88b
to
4c26917
Compare
4c26917
to
9b979ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
+ | ||
For more information on how to update your cluster version, see _Updating a cluster using the web console_ or _Updating a cluster using the CLI_. | ||
* You have installed the OpenShift CLI (`oc`) that matches the version for your current cluster. | ||
* Your `oc` client is updated to at least verion 4.13.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for bikeshedding, but since we already ask for Your {product-title} version is up to date to at least version 4.13.0.
and to have You have installed the OpenShift CLI ('oc') that matches the version for your current cluster.
mentioning Your 'oc' client is updated to at least verion 4.13.0.
may be redundant
+ | ||
[source,terminal] | ||
---- | ||
$ oc get clusterversion/version -o=jsonpath="{.status.conditions[?(.type=='RetrievedUpdates')].status}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as the command is concerned, if what we're after is not to expose too much cvo internals, we may as well only ask the user to check oc adm upgrade
out, verifying there's no "RetrievedUpates=False" in the output, and if there is, to address it following the message prior to progressing any further. we may as well suggest ignoring "Upgradeable=False", which (overrides aside) should not interfere with the procedure. imho, a lack of RetrievedUpates=False in the output should be good enough to assume RetrievedUpates=True
all in all, this doc looks good to me. you can address my two comments above, or can ignore them as well since none of them is a deal breaker in any sense :) |
merge review lgtm |
/cherrypick enterprise-4.13 |
@skrthomas: new pull request created: #58798 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding documentation to support https://issues.redhat.com/browse/OTA-653.
Version(s):
4.13+
Issue:
https://issues.redhat.com/browse/OSDOCS-5665
Link to docs preview:
https://58104--docspreview.netlify.app/openshift-enterprise/latest/updating/migrating-to-multi-payload.html
QE review:
Additional information: