Skip to content

Conversation

obrown1205
Copy link
Contributor

@obrown1205 obrown1205 commented Mar 31, 2023

Adding documentation to support https://issues.redhat.com/browse/OTA-653.

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-5665

Link to docs preview:
https://58104--docspreview.netlify.app/openshift-enterprise/latest/updating/migrating-to-multi-payload.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 31, 2023

🤖 Updated build preview is available at:
https://58104--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14152

@petr-muller
Copy link
Member

/cc

@openshift-ci openshift-ci bot requested a review from petr-muller April 3, 2023 12:44
@obrown1205 obrown1205 force-pushed the multiarch_migrate branch 5 times, most recently from d2470ce to 6cc0ea7 Compare April 3, 2023 18:00
@shellyyang1989
Copy link

cc @aleskandro for review from multi-arch side. Thank you!

@evakhoni
Copy link

evakhoni commented Apr 4, 2023

few important notes:

  1. before the transition one must verify RetrievedUpdates=True in cvo conditions, otherwise the command will not progress (like I've mentioned in OCPBUGS-8252)
  2. probably worth mentioning to update the oc client to the same version as the server in prerequisites, otherwise one may have an older oc with no support for --to-multi-arch
  3. worth mentioning that the transition is one-way (i.e. once a cluster is transitioned to multi arch, it can no longer return back to single, neither can accept a non-multi-arch upgrade payload. with that said, AFAIK we're encouraging the customers to transition, so we may want to choice a language that won't scare them away

Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some stuff with multi-arch in mind. Looks great!

@obrown1205 obrown1205 force-pushed the multiarch_migrate branch 2 times, most recently from 62583de to cf2d738 Compare April 4, 2023 19:41
@obrown1205 obrown1205 force-pushed the multiarch_migrate branch 2 times, most recently from 03440f3 to f962f2f Compare April 5, 2023 14:04
@obrown1205
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 5, 2023
@skrthomas skrthomas removed the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 5, 2023
@obrown1205 obrown1205 force-pushed the multiarch_migrate branch 4 times, most recently from f075c9e to 52da7eb Compare April 12, 2023 20:59
@shellyyang1989
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 13, 2023
@obrown1205 obrown1205 force-pushed the multiarch_migrate branch 3 times, most recently from 7906fcd to 472d88b Compare April 13, 2023 13:57
@skrthomas skrthomas added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 13, 2023
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023
+
For more information on how to update your cluster version, see _Updating a cluster using the web console_ or _Updating a cluster using the CLI_.
* You have installed the OpenShift CLI (`oc`) that matches the version for your current cluster.
* Your `oc` client is updated to at least verion 4.13.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for bikeshedding, but since we already ask for Your {product-title} version is up to date to at least version 4.13.0.
and to have You have installed the OpenShift CLI ('oc') that matches the version for your current cluster.
mentioning Your 'oc' client is updated to at least verion 4.13.0. may be redundant

+
[source,terminal]
----
$ oc get clusterversion/version -o=jsonpath="{.status.conditions[?(.type=='RetrievedUpdates')].status}"
Copy link

@evakhoni evakhoni Apr 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as the command is concerned, if what we're after is not to expose too much cvo internals, we may as well only ask the user to check oc adm upgrade out, verifying there's no "RetrievedUpates=False" in the output, and if there is, to address it following the message prior to progressing any further. we may as well suggest ignoring "Upgradeable=False", which (overrides aside) should not interfere with the procedure. imho, a lack of RetrievedUpates=False in the output should be good enough to assume RetrievedUpates=True

@evakhoni
Copy link

all in all, this doc looks good to me. you can address my two comments above, or can ignore them as well since none of them is a deal breaker in any sense :)

@skrthomas
Copy link
Contributor

merge review lgtm

@skrthomas skrthomas merged commit 5ae5408 into openshift:main Apr 17, 2023
@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@skrthomas: new pull request created: #58798

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.