-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[enterprise-4.13] [OSDOCS-5240] Installer support to automatically create the MachineSets when installing in existing VPC on AWS w/Local Zones #59950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maxwelldb
merged 42 commits into
openshift:enterprise-4.13
from
openshift-cherrypick-robot:cherry-pick-57427-to-enterprise-4.13
May 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely to remove if the smoother CloudFormation flows can be preserved.
Co-authored-by: Marco Braga <braga@mtulio.eng.br>
Co-authored-by: Yunfei Jiang <61686698+yunjiang29@users.noreply.github.com> Co-authored-by: Marco Braga <braga@mtulio.eng.br>
Co-authored-by: Yunfei Jiang <61686698+yunjiang29@users.noreply.github.com>
This reverts commit a15f2b9.
Co-authored-by: Marco Braga <braga@mtulio.eng.br>
Co-authored-by: Marco Braga <braga@mtulio.eng.br>
…penshift#3) * simplifying the zone group explanation * Update modules/installation-aws-add-local-zone-locations.adoc Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com> --------- Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>
…s on the structure (openshift#4) * OSDOCS-5240 openshift#57427: review rendered page with important fixes on the structure * Apply suggestions from code review Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com> --------- Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>
Co-authored-by: Marco Braga <braga@mtulio.eng.br>
Co-authored-by: Yunfei Jiang <61686698+yunjiang29@users.noreply.github.com>
Co-authored-by: Yunfei Jiang <61686698+yunjiang29@users.noreply.github.com>
1 task
maxwelldb
added a commit
to maxwelldb/openshift-docs
that referenced
this pull request
May 15, 2023
…eate the MachineSets when installing in existing VPC on AWS w/Local Zones (openshift#59950) Co-authored-by: Max Bridges <mbridges@redhat.com> Co-authored-by: Marco Braga <braga@mtulio.eng.br> Co-authored-by: Yunfei Jiang <61686698+yunjiang29@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57427
/assign maxwelldb