Skip to content

Conversation

rh-max
Copy link
Contributor

@rh-max rh-max commented Jul 19, 2023

Version(s):
Serverless 1.29+ (CP to branches serverless-docs-1.29 and serverless-docs-1.30)

Issue:
https://issues.redhat.com/browse/SRVKS-1081
https://issues.redhat.com/browse/SRVCOM-2511

Link to docs preview:
https://62581--docspreview.netlify.app/openshift-serverless/latest/about/serverless-release-notes.html#serverless-rn-1-29-1_serverless-release-notes

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 19, 2023

🤖 Updated build preview is available at:
https://62581--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/21090

@rh-max
Copy link
Contributor Author

rh-max commented Jul 19, 2023

@mgencur Hi Martin, could you PTAL?

@rh-max
Copy link
Contributor Author

rh-max commented Jul 25, 2023

@mgencur Thank you, Martin! All suggestions implemented.

@mgencur
Copy link
Contributor

mgencur commented Jul 25, 2023

@rh-max Thanks :-) LGTM

@rh-max
Copy link
Contributor Author

rh-max commented Jul 25, 2023

/label serverless
/label peer-review-needed

@openshift-ci openshift-ci bot added serverless Label for all Serverless PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 25, 2023
@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 25, 2023
@stevsmit stevsmit added this to the Continuous Release milestone Jul 25, 2023
@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 25, 2023
@stevsmit
Copy link
Member

This LGTM. Your commits need squashed before pushing to merge review.

Re-work Serverless 1.29.1 release notes

Add the release notes template module
@rh-max rh-max force-pushed the srvls-release-notes-1.29.1 branch from 990cdcd to e98cb11 Compare August 3, 2023 06:22
@Preeticp Preeticp added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 3, 2023
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 3, 2023
@mburke5678 mburke5678 merged commit ec9de43 into openshift:serverless-docs Aug 3, 2023
@mburke5678
Copy link
Contributor

/cherrypick serverless-docs-1.29

@mburke5678
Copy link
Contributor

/cherrypick serverless-docs-1.30

@openshift-cherrypick-robot

@mburke5678: new pull request created: #63143

In response to this:

/cherrypick serverless-docs-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #63144

In response to this:

/cherrypick serverless-docs-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants