Skip to content

Conversation

mjpytlak
Copy link
Contributor

@mjpytlak mjpytlak commented Jul 27, 2023

Version(s):
4.14

Issue:
This PR addresses osdocs-6278.

Link to docs preview:

Three-node cluster support for Nutanix

QE review:

  • QE has approved this change.

@mjpytlak mjpytlak added this to the Planned for 4.14 GA milestone Jul 27, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 27, 2023

🤖 Updated build preview is available at:
https://62852--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/21069

@mjpytlak
Copy link
Contributor Author

@sgaoshang Release note for Nutanix three-node cluster support is ready for QE review. PTAL.

@sgaoshang
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@mjpytlak mjpytlak added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 2, 2023
@sabrinajess
Copy link
Contributor

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 2, 2023

[id="ocp-4-14-nutanix-three-node"]
==== Three-node cluster support for Nutanix
With {product-title} {product-version}, deploying a three-node cluster is supported on Nutanix. This type of {product-title} cluster is a smaller, more resource efficient cluster, as it consists of only three control plane machines, which also act as compute machines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second sentence seems a little long for minimalism purposes, and I'm not sure if "as it" will work well in translation. Suggested rewrite below, but only use if it resonates with you. Not a deal-breaker. LGTM once you resolve the merge conflict. @ousleyp - any additional feedback?

Deploying a three-node cluster is supported on Nutanix as of {product-title} {product-version}. This type of {product-title} cluster is more resource-efficient because the three control plane machines also act as compute machines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I agree with Sabrina's review. Otherwise LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabrinajess Thanks for the suggestions. I modified slightly but retained most of the original language as this is the language PM wanted to use when we shipped three-node support for other providers in earlier releases.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

New changes are detected. LGTM label has been removed.

@ousleyp ousleyp added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 2, 2023
@mjpytlak mjpytlak merged commit e754f37 into openshift:enterprise-4.14 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants