Skip to content

[enterprise-4.12] OSDOCS-7126: Added vCenter requirements section to vSphere UPI docs #62868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2023
Merged

[enterprise-4.12] OSDOCS-7126: Added vCenter requirements section to vSphere UPI docs #62868

merged 1 commit into from
Aug 10, 2023

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jul 27, 2023 •
edited by kalexand-rh
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 27, 2023 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-6143 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 27, 2023 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-6143 which is a valid jira issue.

In response to this:

OSDOCS-6143

Version(s):
4.12

Previews:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2023
@ocpdocs-previewbot
Copy link

🤖 Build preview is available at:
https://62868--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/20674

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2023 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-6143 which is a valid jira issue.

In response to this:

Cherry-picked from commit #60436

OSDOCS-6143

Version(s):
4.12

Previews:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 28, 2023
@JoeAldinger
Copy link
Contributor

@dfitzmau has this gone through peer-review? I'm going to remove it from the merge queue till I hear back to avoid confusion.

@JoeAldinger JoeAldinger removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 28, 2023
@JoeAldinger
Copy link
Contributor

Cherry-picked from 94ad17f xref #60436

@JoeAldinger JoeAldinger changed the title OSDOCS-6143: Added vCenter requirements section to vSphere UPI docs [enterprise-4.12] OSDOCS-6143: Added vCenter requirements section to vSphere UPI docs Jul 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2023 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-6143 which is a valid jira issue.

In response to this:

Cherry-picked from commit #60436

OSDOCS-7126

Version(s):
4.12

Previews:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh changed the title [enterprise-4.12] OSDOCS-6143: Added vCenter requirements section to vSphere UPI docs [enterprise-4.12] OSDOCS-7126: Added vCenter requirements section to vSphere UPI docs Jul 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2023 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-7126 which is a valid jira issue.

In response to this:

Cherry-picked from commit #60436

OSDOCS-7126

Version(s):
4.12

Previews:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 labels Jul 28, 2023
@kalexand-rh kalexand-rh added this to the Continuous Release milestone Jul 28, 2023
@racedo
Copy link

racedo commented Jul 31, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@sgaoshang
Copy link

/lgtm

@rvanderp3
Copy link
Contributor

LGTM

@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 10, 2023
@dfitzmau
Copy link
Contributor Author

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 10, 2023
@dfitzmau
Copy link
Contributor Author

@JoeAldinger . Ready for merging.

@JoeAldinger JoeAldinger added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 10, 2023
@JoeAldinger JoeAldinger merged commit 64e1e9f into openshift:enterprise-4.12 Aug 10, 2023
@JoeAldinger JoeAldinger removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@racedo racedo

@sgaoshang sgaoshang

Labels

branch/enterprise-4.12 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @JoeAldinger @racedo @sgaoshang @rvanderp3 @kalexand-rh