Skip to content

[DOCS] OBSDOCS-475 - Logging 5.6.11 & 5.5.16 Release Notes #64617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2023
Merged

[DOCS] OBSDOCS-475 - Logging 5.6.11 & 5.5.16 Release Notes #64617

merged 1 commit into from
Sep 20, 2023

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Sep 12, 2023 •
edited
Loading

Change type: Doc update; Logging Z-Stream Release Notes - 5.6.11 & 5.5.16
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-475

Fix Version: 4.10, 4.11, and 4.12

Doc Previews:
For 5.6.11: https://64617--docspreview.netlify.app/openshift-enterprise/latest/logging/v5_6/logging-5-6-release-notes
For 5.5.16: https://64617--docspreview.netlify.app/openshift-enterprise/latest/logging/v5_5/logging-5-5-release-notes

SME Review: @xperimental
QE Review: @kabirbhartiRH
Peer Review: @agantony

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2023
@ocpdocs-previewbot
Copy link

🤖 Build preview is available at:
https://64617--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/24613

@kabirbhartiRH
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@xperimental
Copy link
Contributor

/lgtm

@shreyasiddhartha
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 18, 2023
@agantony
Copy link
Contributor

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 18, 2023
agantony
agantony reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions; lgtm

@agantony
Copy link
Contributor

Comments are to be double-checked. Please do not mark it as review completed.

@briandooley
Copy link
Contributor

Going to leave this as it as as I believe that it follows the current guidelines.

@agantony Could you please label this as peer-review-complete please?

We have to get this PR out very soon. Thanks for your review.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@shreyasiddhartha shreyasiddhartha changed the title [WIP] OBSDOCS-475 - Logging 5.6.11 & 5.5.16 Release Notes [DOCS] OBSDOCS-475 - Logging 5.6.11 & 5.5.16 Release Notes Sep 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023
@agantony
Copy link
Contributor

agantony commented Sep 20, 2023 •
edited
Loading

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 20, 2023
@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 20, 2023
@shreyasiddhartha
Copy link
Contributor Author

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 20, 2023
@shreyasiddhartha
Copy link
Contributor Author

/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done

Removed peer-review-in-progress label as it did not get removed when prompted earlier. Also, since peer review is complete.

@kelbrown20 kelbrown20 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 20, 2023
kelbrown20
kelbrown20 reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyasiddhartha Hello! This PR LGTM and merging!
Though I see that this PR is off of enterprise-4.10 and the fixed versions are for 4.10, 4.11, 4.12. This PR will only update enterprise-4.10, if you want the changes to apply to enterprise-4.11 / 4.12, you will need to create two more separate PRs off of those branches.

@kelbrown20 kelbrown20 merged commit 87e15a9 into openshift:enterprise-4.10 Sep 20, 2023
@kelbrown20 kelbrown20 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 20, 2023
@kelbrown20 kelbrown20 mentioned this pull request Sep 20, 2023
Closed
This was referenced Sep 20, 2023
Merged
Merged
@shreyasiddhartha
Copy link
Contributor Author

@shreyasiddhartha Hello! This PR LGTM and merging! Though I see that this PR is off of enterprise-4.10 and the fixed versions are for 4.10, 4.11, 4.12. This PR will only update enterprise-4.10, if you want the changes to apply to enterprise-4.11 / 4.12, you will need to create two more separate PRs off of those branches.

Hi @kelbrown20! Thanks for letting me know. :) I have created two more PRs for the 4.11 and 4.12. It would be great if you could take a look.

4.11: #64983
4.12: #64981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandooley briandooley briandooley left review comments

@agantony agantony agantony left review comments

+2 more reviewers

@bburt-rh bburt-rh bburt-rh left review comments

@kelbrown20 kelbrown20 kelbrown20 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@xperimental xperimental

@kabirbhartiRH kabirbhartiRH

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shreyasiddhartha @ocpdocs-previewbot @kabirbhartiRH @xperimental @agantony @briandooley @bburt-rh @kelbrown20