Skip to content

MIG 1418 Release notes fixed #64678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MIG 1418 Release notes fixed #64678

wants to merge 1 commit into from

Conversation

CarmiWisemon
Copy link
Contributor

@CarmiWisemon CarmiWisemon commented Sep 13, 2023 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 13, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://64678--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26216

rayfordj
rayfordj suggested changes Sep 21, 2023
View reviewed changes
Copy link

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention BZ#2236829 as a known-issue for MTC 1.8?

#L24-L26

.Old restic pods are not removed when upgrading MTC 1.7.x to MTC 1.8

On upgrading the MTC operator from 1.7.x to 1.8.x, the old restic pods are not removed. After the upgrade, both restic and node-agent pods are visible in the namespace. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2236829[*BZ#2236829*])

@CarmiWisemon CarmiWisemon force-pushed the mig1418rnfix branch 2 times, most recently from 68f12e6 to 3c3eeee Compare September 26, 2023 10:07
rayfordj
rayfordj reviewed Sep 26, 2023
View reviewed changes
@rayfordj
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@rayfordj rayfordj removed their assignment Sep 26, 2023
stillalearner
stillalearner approved these changes Sep 27, 2023
View reviewed changes
Copy link

@stillalearner stillalearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rayfordj
rayfordj approved these changes Sep 27, 2023
View reviewed changes
Copy link

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@rayfordj rayfordj removed their assignment Sep 27, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

New changes are detected. LGTM label has been removed.

RichardHoch
RichardHoch reviewed Sep 28, 2023
View reviewed changes
RichardHoch
RichardHoch reviewed Sep 28, 2023
View reviewed changes
RichardHoch
RichardHoch reviewed Sep 28, 2023
View reviewed changes
RichardHoch
RichardHoch reviewed Sep 28, 2023
View reviewed changes
RichardHoch
RichardHoch reviewed Sep 28, 2023
View reviewed changes
RichardHoch
RichardHoch reviewed Sep 28, 2023
View reviewed changes
RichardHoch
RichardHoch reviewed Sep 28, 2023
View reviewed changes
RichardHoch
RichardHoch reviewed Sep 28, 2023
View reviewed changes
RichardHoch
RichardHoch reviewed Sep 28, 2023
View reviewed changes
@RichardHoch
Copy link
Contributor

Looks pretty good -- a number of small comments, but good, clear writing.

@CarmiWisemon CarmiWisemon force-pushed the mig1418rnfix branch 2 times, most recently from b96004e to 9eaa3b3 Compare September 28, 2023 12:05
@CarmiWisemon
Copy link
Contributor Author

/label MTC
/label peer-review-needed

1 similar comment
@michaelryanpeter
Copy link
Contributor

/label MTC
/label peer-review-needed

@openshift-ci openshift-ci bot added MTC Label for all MTC PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 28, 2023
@michaelryanpeter michaelryanpeter removed peer-review-needed Signifies that the peer review team needs to review this PR MTC Label for all MTC PRs labels Sep 28, 2023
@michaelryanpeter
Copy link
Contributor

/label MTC
/label peer-review-needed

@openshift-ci openshift-ci bot added MTC Label for all MTC PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 28, 2023
@michaelryanpeter michaelryanpeter removed peer-review-needed Signifies that the peer review team needs to review this PR MTC Label for all MTC PRs labels Sep 28, 2023
@RichardHoch
Copy link
Contributor

@michaelryanpeter Hi -- please do not review the PR. We just got a last minute change here. Sorry. Please attach a "no need fir review" or "review complete" label to the PR. Sorry for the bother.

This was referenced Sep 28, 2023
Merged
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anarnold97
Copy link
Contributor

@CarmiWisemon - please close this PR. Thanks

@CarmiWisemon
Copy link
Contributor Author

@anarnold97
Thank you for your help. I added the link to the published release notes in the Jira. In Jira it's already listed as Done, and I don't see an option to Close it.

@anarnold97
Copy link
Contributor

Ok I meant close this PR and you can delete the branch but I will walk you through it tomorrow:
image

@CarmiWisemon
Copy link
Contributor Author

https://access.redhat.com/documentation/en-us/openshift_container_platform/4.13/html-single/migration_toolkit_for_containers/index#migration-mtc-release-notes-1-8_mtc-release-notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@RichardHoch RichardHoch RichardHoch left review comments

@anarnold97 anarnold97 anarnold97 left review comments

@rayfordj rayfordj rayfordj approved these changes

@stillalearner stillalearner stillalearner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@CarmiWisemon @ocpdocs-previewbot @rayfordj @RichardHoch @michaelryanpeter @openshift-merge-robot @anarnold97 @stillalearner