Skip to content

[enterprise-4.14] OSDOCS-7556: add RN entry #64903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

[enterprise-4.14] OSDOCS-7556: add RN entry #64903

merged 1 commit into from
Sep 25, 2023

Conversation

jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Sep 19, 2023 •
edited
Loading

@jldohmann jldohmann added this to the Planned for 4.14 GA milestone Sep 19, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2023 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7556 which is a valid jira issue.

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/OSDOCS-7556

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2023
@jldohmann
Copy link
Contributor Author

@rioliu-rh could you PTAL at this for QE ack? This is a OCP 4.14 RN entry for the new feature that exposes additional MCO metrics in Prometheus

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 19, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://64903--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/25326

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2023 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7556 which is a valid jira issue.

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/OSDOCS-7556

Link to docs preview: https://64903--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes#ocp-4-14-additional-prometheus-metrics

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 19, 2023
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 20, 2023
snarayan-redhat
snarayan-redhat reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Couple of suggestions.

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 20, 2023
@sergiordlr
Copy link

lgtm

Thank you very much!!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2023 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-7556 which is a valid jira issue.

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/OSDOCS-7556

Link to docs preview: https://64903--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes#ocp-4-14-additional-prometheus-metrics

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann merged commit e8d3bec into openshift:enterprise-4.14 Sep 25, 2023
@jldohmann jldohmann deleted the OSDOCS-7556-RN branch September 25, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snarayan-redhat snarayan-redhat snarayan-redhat left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.14 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@jldohmann @openshift-ci-robot @ocpdocs-previewbot @sergiordlr @snarayan-redhat @openshift-merge-robot