OCPBUGS-19644 Adding per-pod-power-management to output of help

[kquinn1204]

[OCPBUGS-19644]: per-pod-power-management missing from output of podman run

Version(s): 4.12, 4.13, 4.14, main

Issue:https://issues.redhat.com/browse/OCPBUGS-19644

Link to docs preview: https://65512--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-create-performance-profiles.html#running-the-performance-profile-profile-cluster-using-podman_cnf-create-performance-profiles

QE review:

• QE has approved this change.

Additional information: Simple update to the output of a command which did not reflect the addition of a new option. I checked myself and QE verified that help was updated.

[ocpdocs-previewbot]

🤖 Updated build preview is available at:
https://65512--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/28844

[kquinn1204]

@mrniranjan PTAL a look at this update to ensure output of podman run --rm --entrypoint performance-profile-creator registry.redhat.io/openshift4/ose-cluster-node-tuning-operator:v4.13 -h reflects the added --per-pod-power-management

[mrniranjan]

looks good to me

[kquinn1204]

/label telco

[kquinn1204]

/label merge-review-needed

[michaelryanpeter]

This is a friendly reminder that PRs have to go through peer review before being added to the merge review queue.

/remove-label merge-review-needed
/label peer-review-needed

[kquinn1204]

/label peer-review-needed

[mburke5678]

@kquinn1204 I think that it should be per-pod power management, from the references I can find in an internet search.

[kquinn1204]

@mburke5678 I verified on a live cluster

A tool that automates creation of Performance Profiles

Usage:
  performance-profile-creator [flags]

Flags:
      --disable-ht                        Disable Hyperthreading
  -h, --help                              help for performance-profile-creator
      --info string                       Show cluster information; requires --must-gather-dir-path, ignore the other arguments. [Valid values: log, json] (default "log")
      --mcp-name string                   MCP name corresponding to the target machines (required)
      --must-gather-dir-path string       Must gather directory path (default "must-gather")
      --offlined-cpu-count int            Number of offlined CPUs
      --per-pod-power-management          Enable Per Pod Power Management
      --power-consumption-mode string     The power consumption mode.  [Valid values: default, low-latency, ultra-low-latency] (default "default")
      --profile-name string               Name of the performance profile to be created (default "performance")
      --reserved-cpu-count int            Number of reserved CPUs (required)
      --rt-kernel                         Enable Real Time Kernel (required)
      --split-reserved-cpus-across-numa   Split the Reserved CPUs across NUMA nodes
      --topology-manager-policy string    Kubelet Topology Manager Policy of the performance profile to be created. [Valid values: single-numa-node, best-effort, restricted] (default "restricted")
      --user-level-networking             Run with User level Networking(DPDK) enabled

[kquinn1204]

@mburke5678 I had to do a double take but verified again just now

[kquinn1204]

/label merge-review-needed

[opayne1]

This isn't part of your PR, but Per Pod Power Management is written as per-pod power management in this table. I feel like maybe it should be consistent? Let me know if you would like to fix in this PR or if you would like to fix in another PR.

[kquinn1204]

I will address here shortly and change to Enable per pod power management thanks for picking that up. @opayne1

[kquinn1204]

Hi @opayne1 thanks for review, hopefully OK to merge now

[opayne1]

/cherrypick enterprise-4.12

[opayne1]

/cherrypick enterprise-4.13

[opayne1]

/cherrypick enterprise-4.14

[openshift-cherrypick-robot]

@opayne1: new pull request created: #66530

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@opayne1: new pull request created: #66531

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@opayne1: new pull request created: #66532

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.