Nodes hiding Graceful Node Shutdown release note

[mburke5678]

Removing the Graceful node shutdown feature from Release Notes, as not supported.

https://issues.redhat.com/browse/OCPBUGS-17478

Current docs -- Graceful shutdown release note, right after Pod Disruption Budget release note.
Preview Release note after PDB removed.

QE review: No QE review needed

PR to remove graceful node shutdown from docs.

[ocpdocs-previewbot]

🤖 Updated build preview is available at:
https://65843--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27009

[rphillips]

/lgtm

[openshift-ci]

New changes are detected. LGTM label has been removed.

[nalhadef]

Hi, @mburke5678. Can you explain to me:

• Why this blurb has been removed from the release notes. The condition is supported for 4.14.
• A second PR was created to remove the relevant text from the documentation.?

Thanks for filling me in.

Neal

@lsvenkat

[snarayan-redhat]

I do see that Neal has already looked into the PR. I will wait until the conversation is done to mark review done.However, I have just one question. Is it intentional to 'hide' the note instead of just 'remove'?

[nalhadef]

Thanks, Shuba. I'm waiting to hear from Michael why this material is being removed. I worked with the developers to insert it.

…

On Mon, Oct 16, 2023 at 8:15 AM Shubha Narayanan ***@***.***> wrote: ***@***.**** commented on this pull request. I do see that Neal has already looked into the PR. I will wait until the conversation is done to mark review done.However, I have just one question. Is it intentional to 'hide' the note instead of just 'remove'? — Reply to this email directly, view it on GitHub <#65843 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT7EEZZQG5POVWDJRUZ7UC3X7UQNFAVCNFSM6AAAAAA5UXR3EOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNZZHAZDCMBVG4> . You are receiving this because you commented.Message ID: ***@***.***>

[mburke5678]

@nalhadef I was asked by Ryan Phillips, Node team lead, to remove the feature as: "We are not enabling Graceful Shutdowns by default within OpenShift yet. We are trying to enable the feature, but there are cases we are running into where networking does not get enabled at boot."
The removal was also requested via https://issues.redhat.com/browse/OCPBUGS-17478.

[nalhadef]

Thanks, Michael. I'll run this buy the Installer devs and if they have a problem, maybe they can work it out with Ryan. Neal

…

On Mon, Oct 16, 2023 at 8:58 AM Michael Burke ***@***.***> wrote: @nalhadef <https://github.com/nalhadef> I was asked by Ryan Phillips, Node team lead, to remove the feature as: "We are not enabling Graceful Shutdowns by default within OpenShift yet. We are trying to enable the feature, but there are cases we are running into where networking does not get enabled at boot." The removal was also requested via https://issues.redhat.com/browse/OCPBUGS-17478. — Reply to this email directly, view it on GitHub <#65843 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT7EEZY4MF6V4UK4VGAVUMTX7UVP3AVCNFSM6AAAAAA5UXR3EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUGQZTENZSGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[snarayan-redhat]

Thanks, Michael. I'll run this buy the Installer devs and if they have a problem, maybe they can work it out with Ryan. Neal
…
On Mon, Oct 16, 2023 at 8:58 AM Michael Burke @.> wrote: @nalhadef https://github.com/nalhadef I was asked by Ryan Phillips, Node team lead, to remove the feature as: "We are not enabling Graceful Shutdowns by default within OpenShift yet. We are trying to enable the feature, but there are cases we are running into where networking does not get enabled at boot." The removal was also requested via https://issues.redhat.com/browse/OCPBUGS-17478. — Reply to this email directly, view it on GitHub <#65843 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7EEZY4MF6V4UK4VGAVUMTX7UVP3AVCNFSM6AAAAAA5UXR3EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUGQZTENZSGI . You are receiving this because you were mentioned.Message ID: @.>

Neal,
Do you want this PR to be in the peer review radar? if not, I will remove the peer review labels.

[nalhadef]

Hi, Shubha. I don't see a need for a peer review if the content is going to be removed. If you, Michael, or anyone else disagree, I'm happy to have it reviewed. Thanks! On Mon, Oct 16, 2023 at 10:22 AM Shubha Narayanan ***@***.***> wrote:

…

Thanks, Michael. I'll run this buy the Installer devs and if they have a problem, maybe they can work it out with Ryan. Neal … <#m_6082730867877913890_> On Mon, Oct 16, 2023 at 8:58 AM Michael Burke *@*.*> wrote: @nalhadef <https://github.com/nalhadef> https://github.com/nalhadef <https://github.com/nalhadef> I was asked by Ryan Phillips, Node team lead, to remove the feature as: "We are not enabling Graceful Shutdowns by default within OpenShift yet. We are trying to enable the feature, but there are cases we are running into where networking does not get enabled at boot." The removal was also requested via https://issues.redhat.com/browse/OCPBUGS-17478 <https://issues.redhat.com/browse/OCPBUGS-17478>. — Reply to this email directly, view it on GitHub <#65843 (comment) <#65843 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT7EEZY4MF6V4UK4VGAVUMTX7UVP3AVCNFSM6AAAAAA5UXR3EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUGQZTENZSGI <https://github.com/notifications/unsubscribe-auth/AT7EEZY4MF6V4UK4VGAVUMTX7UVP3AVCNFSM6AAAAAA5UXR3EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUGQZTENZSGI> . You are receiving this because you were mentioned.Message ID: @.*> Neal, Do you want this PR to be in the peer review radar? if not, I will remove the peer review labels. — Reply to this email directly, view it on GitHub <#65843 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT7EEZ3SCYIC3ZB7ENGJ7WTX7U7LFAVCNFSM6AAAAAA5UXR3EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUGU4TENBTGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[snarayan-redhat]

Thanks for confirming, Neal. I will remove the labels.

[kalexand-rh]

https://issues.redhat.com/browse/OCPNODE-549 is the in-progress issue to implement the feature. Based on my understanding of the situation, this needs to be removed.

[GroceryBoyJr]

....reviewing @kalexand-rh comment.

[GroceryBoyJr]

Agreed with @kalexand-rh read of the issue, this needs to be removed.

[GroceryBoyJr]

LGTM

[GroceryBoyJr]

/label peer-review-done
/remove-label peer-review-needed