Skip to content

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Oct 5, 2023

MIG-1449

Merge failed to Enterprise 4.11 → branch/enterprise-4.11

Issue:

Link to docs preview:

MTC release notes

QE review:

  • [ X] QE has approved this change. - Reviewed by Rayford Johnson

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023

@anarnold97: This pull request references MIG-1449 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anarnold97 anarnold97 changed the title MIG-1449: Release notes catch-up MIG-1449: Release notes catch-up for 4.11 Oct 5, 2023
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023

@anarnold97: This pull request references MIG-1449 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 5, 2023

🤖 Updated build preview is available at:
https://65848--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27027

@anarnold97 anarnold97 force-pushed the MIG-1449-release-notes branch from 3b8376b to 40e365c Compare October 5, 2023 21:45
@anarnold97
Copy link
Contributor Author

/label mtc

@openshift-ci openshift-ci bot added the MTC Label for all MTC PRs label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023

@anarnold97: This pull request references MIG-1449 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023

@anarnold97: This pull request references MIG-1449 which is a valid jira issue.

In response to this:

MIG-1449

Merge failed to Enterprise 4.11 → branch/enterprise-4.11

Issue:

Link to docs preview:

MTC release notes

QE review:

  • [ X] QE has approved this change. - Reviewed by Rayford Johnson

Additional information:

@anarnold97
Copy link
Contributor Author

/label merge-review-needed

Fixing error for 4.11 merge see comment for details

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023

@anarnold97: This pull request references MIG-1449 which is a valid jira issue.

In response to this:

MIG-1449

Merge failed to Enterprise 4.11 → branch/enterprise-4.11

Issue:

Link to docs preview:

MTC release notes

QE review:

  • [ X] QE has approved this change. - Reviewed by Rayford Johnson

Additional information:

@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023

@anarnold97: This pull request references MIG-1449 which is a valid jira issue.

In response to this:

MIG-1449

Merge failed to Enterprise 4.11 → branch/enterprise-4.11

Issue:

Link to docs preview:

MTC release notes

QE review:

  • [ X] QE has approved this change. - Reviewed by Rayford Johnson

Additional information:

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023

@anarnold97: This pull request references MIG-1449 which is a valid jira issue.

In response to this:

MIG-1449

Merge failed to Enterprise 4.11 → branch/enterprise-4.11

Issue:

Link to docs preview:

MTC release notes

QE review:

  • [ X] QE has approved this change. - Reviewed by Rayford Johnson

Additional information:

Copy link
Contributor

@bscott-rh bscott-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits and minor comments.

@anarnold97
Copy link
Contributor Author

@bscott-rh - good spots. I will need a couple of hours to get back to this. I will have to update the complete set for 4.12, 4.13, 4.14 as well as so it is going to take about an hour, but I am on it.

It might be easier to make a new PR for those version and copy you in, if that is ok with you, please

@bscott-rh
Copy link
Contributor

@bscott-rh - good spots. I will need a couple of hours to get back to this. I will have to update the complete set for 4.12, 4.13, 4.14 as well as so it is going to take about an hour, but I am on it.

It might be easier to make a new PR for those version and copy you in, if that is ok with you, please

No problem, I'll review those PRs whenever you've got them. I think that would be necessary anyways because this PR is 4.11 only. Thanks

@anarnold97 anarnold97 force-pushed the MIG-1449-release-notes branch from e122ad8 to 7ce6a85 Compare October 6, 2023 16:15
@bscott-rh bscott-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023

@anarnold97: This pull request references MIG-1449 which is a valid jira issue.

In response to this:

MIG-1449

Merge failed to Enterprise 4.11 → branch/enterprise-4.11

Issue:

Link to docs preview:

MTC release notes

QE review:

  • [ X] QE has approved this change. - Reviewed by Rayford Johnson

Additional information:

@bscott-rh
Copy link
Contributor

No additional peer review was conducted because this was a cherrypick. Merge review LGTM.

@bscott-rh bscott-rh merged commit cc41b04 into openshift:enterprise-4.11 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. MTC Label for all MTC PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants