Skip to content

Conversation

maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Oct 14, 2023

Version(s): 4.14

Issue: OSDOCS-7725

Link to docs preview: https://66243--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes

QE review:

  • QE has approved this change.

Additional information:

  • Root volumes item added by OSDOCS-7545.
  • Bugs are covered outside of this PR.
  • TODO: Cover OSDOCS-6738 in this, too.

@maxwelldb maxwelldb added this to the Planned for 4.14 GA milestone Oct 14, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 14, 2023

🤖 Updated build preview is available at:
https://66243--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/30641

@maxwelldb maxwelldb self-assigned this Oct 14, 2023
@maxwelldb maxwelldb force-pushed the shiftstack-4.14-rns branch from a97d20d to 6107c6b Compare October 14, 2023 17:59
@EmilienM
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@maxwelldb maxwelldb force-pushed the shiftstack-4.14-rns branch 3 times, most recently from a0f9c95 to 4531868 Compare October 20, 2023 13:50
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2023
@maxwelldb maxwelldb force-pushed the shiftstack-4.14-rns branch from 7a87026 to 0d5d0a4 Compare October 20, 2023 18:19
@dulek
Copy link
Contributor

dulek commented Oct 26, 2023

Looks good from my side once @mandre's suggestion gets approved.

@maxwelldb maxwelldb force-pushed the shiftstack-4.14-rns branch from 81e76f6 to e445a59 Compare October 26, 2023 12:12
maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request Oct 26, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2023
maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request Oct 26, 2023
@maxwelldb maxwelldb force-pushed the shiftstack-4.14-rns branch from e445a59 to 2760034 Compare October 26, 2023 12:18
@kalexand-rh
Copy link
Contributor

@eurijon @rlobillo, tomorrow is the last day to merge doc changes before GA. Please confirm this change.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2023
@maxwelldb maxwelldb force-pushed the shiftstack-4.14-rns branch from 2760034 to 4daf3c4 Compare October 26, 2023 21:49
maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request Oct 26, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2023
Copy link

@eurijon eurijon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the two minor comments I've just added.

@maxwelldb maxwelldb requested a review from eurijon October 27, 2023 11:47
@maxwelldb maxwelldb requested a review from eurijon October 27, 2023 12:51
@eurijon
Copy link

eurijon commented Oct 27, 2023

This looks good from my side!

Copy link

@eurijon eurijon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just what seems a typo

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 27, 2023
@maxwelldb maxwelldb requested a review from eurijon October 27, 2023 13:14
@bburt-rh bburt-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 27, 2023
Copy link
Contributor

@bburt-rh bburt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks @maxwelldb.

@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 27, 2023
@maxwelldb maxwelldb force-pushed the shiftstack-4.14-rns branch from 4993ed4 to 75ac4d9 Compare October 27, 2023 14:13
@maxwelldb
Copy link
Contributor Author

Thanks!

@maxwelldb maxwelldb merged commit 28b4b2c into openshift:enterprise-4.14 Oct 27, 2023
@maxwelldb maxwelldb deleted the shiftstack-4.14-rns branch October 27, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.