Skip to content

RHDEVDOCS-5667: Updating install build strategies commands #66333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

RHDEVDOCS-5667: Updating install build strategies commands #66333

merged 1 commit into from
Oct 20, 2023

Conversation

shipsing
Copy link
Contributor

@shipsing shipsing commented Oct 17, 2023 •
edited
Loading

Purpose: To resolve this issue: https://issues.redhat.com/browse/RHDEVDOCS-5667

Aligned team: DevTools

Version for cherrypicking: build-docs-1.0

Content for preview: https://66333--docspreview.netlify.app/openshift-builds/latest/installing/installing-sample-build-strategies

SME review: @apoorvajagtap @jkhelil

QE review: @jitendar-singh

Peer review: @kelbrown20

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2023 •
edited by openshift-ci bot
Loading

@shipsing: This pull request references RHDEVDOCS-5667 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2023 •
edited by openshift-ci bot
Loading

@shipsing: This pull request references RHDEVDOCS-5667 which is a valid jira issue.

In response to this:

Purpose: To resolve this issue: https://issues.redhat.com/browse/RHDEVDOCS-5667

Aligned team: DevTools

Version for cherrypicking: build-docs-1.0

Content for preview:

SME review: @apoorvajagtap @jkhelil

QE review: @jitendar-singh

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 17, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://66333--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/29128

@shipsing shipsing changed the title RHDEVDOCS-5667: Updating install stratagies commands RHDEVDOCS-5667: Updating install build strategies commands Oct 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2023 •
edited by openshift-ci bot
Loading

@shipsing: This pull request references RHDEVDOCS-5667 which is a valid jira issue.

In response to this:

Purpose: To resolve this issue: https://issues.redhat.com/browse/RHDEVDOCS-5667

Aligned team: DevTools

Version for cherrypicking: build-docs-1.0

Content for preview: https://66333--docspreview.netlify.app/openshift-builds/latest/installing/installing-sample-build-strategies

SME review: @apoorvajagtap @jkhelil

QE review: @jitendar-singh

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2023
@apoorvajagtap
Copy link
Contributor

LGTM.

@shipsing
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 18, 2023
@kelbrown20 kelbrown20 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 18, 2023
kelbrown20
kelbrown20 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Just some updates for the xrefs, but otherwise everything else looks good to me!

@kelbrown20 kelbrown20 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 18, 2023
@shipsing
Copy link
Contributor Author

@kelbrown20, I have incorporated your suggestions. Please verify the same. Thank you.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2023 •
edited by openshift-ci bot
Loading

@shipsing: This pull request references RHDEVDOCS-5667 which is a valid jira issue.

In response to this:

Purpose: To resolve this issue: https://issues.redhat.com/browse/RHDEVDOCS-5667

Aligned team: DevTools

Version for cherrypicking: build-docs-1.0

Content for preview: https://66333--docspreview.netlify.app/openshift-builds/latest/installing/installing-sample-build-strategies

SME review: @apoorvajagtap @jkhelil

QE review: @jitendar-singh

Peer review: @kelbrown20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

apoorvajagtap
apoorvajagtap suggested changes Oct 19, 2023
View reviewed changes
@apoorvajagtap
Copy link
Contributor

@shipsing can we add the following command in the common section? Something like:

The following command shall install all the supported clusterBuildStrategies:
$ oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/releases/download/0.1.0/release-strategies.yaml

The pre-requisites for this will be same as we have specified in the individual sections.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2023
@jitendar-singh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2023 •
edited by openshift-ci bot
Loading

@shipsing: This pull request references RHDEVDOCS-5667 which is a valid jira issue.

In response to this:

Purpose: To resolve this issue: https://issues.redhat.com/browse/RHDEVDOCS-5667

Aligned team: DevTools

Version for cherrypicking: build-docs-1.0

Content for preview: https://66333--docspreview.netlify.app/openshift-builds/latest/installing/installing-sample-build-strategies

SME review: @apoorvajagtap @jkhelil

QE review: @jitendar-singh

Peer review: @kelbrown20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shipsing shipsing force-pushed the RHDEVDOCS-5667 branch 2 times, most recently from 772e916 to 007068f Compare October 20, 2023 06:26
apoorvajagtap
apoorvajagtap reviewed Oct 20, 2023
View reviewed changes
@shipsing shipsing force-pushed the RHDEVDOCS-5667 branch 3 times, most recently from ef783b0 to e59c807 Compare October 20, 2023 09:07
@apoorvajagtap
Copy link
Contributor

LGTM.

@shipsing
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 20, 2023
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 20, 2023
@adellape adellape self-assigned this Oct 20, 2023
@adellape adellape added this to the Continuous Release milestone Oct 20, 2023
@adellape adellape added the dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs label Oct 20, 2023
adellape
adellape reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking merge for this, but please see 1 comment in-line.

@adellape adellape merged commit 1fd7720 into openshift:build-docs Oct 20, 2023
@adellape
Copy link
Contributor

/cherrypick build-docs-1.0

@openshift-cherrypick-robot
Copy link

@adellape: new pull request created: #66634

In response to this:

/cherrypick build-docs-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 20, 2023
Merged
@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Preeticp Preeticp Preeticp left review comments

+3 more reviewers

@adellape adellape adellape left review comments

@apoorvajagtap apoorvajagtap apoorvajagtap requested changes

@kelbrown20 kelbrown20 kelbrown20 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adellape adellape

Labels

dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@shipsing @openshift-ci-robot @ocpdocs-previewbot @apoorvajagtap @jitendar-singh @adellape @openshift-cherrypick-robot @Preeticp @kelbrown20