Skip to content

Remove BuildBuildCSIVolume mentions in Tech Preview #66456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Remove BuildBuildCSIVolume mentions in Tech Preview #66456

wants to merge 0 commits into from

Conversation

nebelsprachen
Copy link

@nebelsprachen nebelsprachen commented Oct 18, 2023 •
edited
Loading

• Aligned team: Dev Tools
• JIRA issue: RHDEVDOCS-5595
• SME Review @jkhelil
• QE review: @jitendar-singh
• Peer-review:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2023
@nebelsprachen
Copy link
Author

nebelsprachen commented Oct 18, 2023 •
edited
Loading

Hi @shipsing, @jitendar-singh. @jkhelil , PTAL

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 18, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://66456--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/30777

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 26, 2023
@nebelsprachen
Copy link
Author

/label peer-review-needed
/label enterprise-4.14

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@joaedwar: The label(s) /label enterprise-4.14 cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label peer-review-needed
/label enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 27, 2023
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 27, 2023
jeana-redhat
jeana-redhat reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use the TP snippet here, see below.

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

modules/builds-running-entitled-builds-with-sharedsecret-objects.adoc
Comment on lines 11 to 19
[IMPORTANT]
====
[subs="attributes+"]
The Shared Resources CSI Driver and The Build CSI Volumes are both Technology Preview features, which are not supported with Red Hat production service level agreements (SLAs) and might not be functionally complete. Red Hat does not recommend using them in production. These features provide early access to upcoming product features, enabling customers to test functionality and provide feedback during the development process.
The Shared Resources CSI Driver is a Technology Preview feature, which is not supported with Red Hat production service level agreements (SLAs) and might not be functionally complete. Red Hat does not recommend using this in production. This feature provides early access to upcoming product features, enabling customers to test functionality and provide feedback during the development process.
For more information about the support scope of Red Hat Technology Preview features, see link:https://access.redhat.com/support/offerings/techpreview/[Technology Preview Features Support Scope].
The Shared Resources CSI Driver and the Build CSI Volumes features also belong to the `TechPreviewNoUpgrade` feature set, which is a subset of the current Technology Preview features. You can enable the `TechPreviewNoUpgrade` feature set on test clusters, where you can fully test them while leaving the features disabled on production clusters. Enabling this feature set cannot be undone and prevents minor version updates. This feature set is not recommended on production clusters. See "Enabling Technology Preview features using feature gates" in the following "Additional resources" section.
The Shared Resources CSI Driver feature also belongs to the `TechPreviewNoUpgrade` feature set, which is a subset of the current Technology Preview features. You can enable the `TechPreviewNoUpgrade` feature set on test clusters, where you can fully test them while leaving the features disabled on production clusters. Enabling this feature set cannot be undone and prevents minor version updates. This feature set is not recommended on production clusters. See "Enabling Technology Preview features using feature gates" in the following "Additional resources" section.
====
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why the TP snippet was not used at first, since it was trying to cover two features and therefore plural was needed. However, now that this is a single feature, it would be better to revert to the standard way of doing this. The feature gate explanation should be fine outside of an admonition, so I would suggest this:

:FeatureName: The Shared Resources CSI Driver
include::snippets/technology-preview.adoc[]

The Shared Resources CSI Driver feature also belongs to the `TechPreviewNoUpgrade` feature set, which is a subset of the current Technology Preview features. You can enable the `TechPreviewNoUpgrade` feature set on test clusters, where you can fully test them while leaving the features disabled on production clusters. Enabling this feature set cannot be undone and prevents minor version updates. This feature set is not recommended on production clusters. See "Enabling Technology Preview features using feature gates" in the following "Additional resources" section.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 27, 2023
@nebelsprachen
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 27, 2023
@jeana-redhat
Copy link
Contributor

@joaedwar please get the peer review changes in before merge

/remove-label merge-review-needed

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed merge-review-needed Signifies that the merge review team needs to review this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2023
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2023
@nebelsprachen nebelsprachen mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

+1 more reviewer

@jitendar-singh jitendar-singh jitendar-singh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nebelsprachen @ocpdocs-previewbot @jeana-redhat @jitendar-singh @openshift-merge-robot