Skip to content

Conversation

lahinson
Copy link
Contributor

@lahinson lahinson commented Nov 1, 2023

Version(s): 4.14z

Issue: https://issues.redhat.com/browse/OSDOCS-8167

Link to docs preview: https://67216--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes#ocp-4-14-known-issues (Ctrl+F to "OCPSTRAT-605")

QE review:

  • QE has approved this change.

Additional information: I am following the change management guidelines to add this known issue in between releases.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 1, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 1, 2023

🤖 Updated build preview is available at:
https://67216--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/32456

** Red Hat OpenShift GitOps
** Red Hat OpenShift Service Mesh
** Red Hat OpenShift Pipelines
** Node Feature Discovery Operator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this, the Jira needs updates but based on recent testing this is working on BM: https://issues.redhat.com/browse/MGMT-14668

Otherwise, LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Thanks, Adel!

@jiezhao16
Copy link

/lgtm

@lahinson
Copy link
Contributor Author

lahinson commented Nov 1, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 1, 2023
@mletalie
Copy link
Contributor

mletalie commented Nov 1, 2023

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 1, 2023
@mletalie
Copy link
Contributor

mletalie commented Nov 1, 2023

Hi @lahinson, one comment, but otherwise LGTM!

@mletalie
Copy link
Contributor

mletalie commented Nov 1, 2023

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@mletalie
Copy link
Contributor

mletalie commented Nov 1, 2023

/lgtm

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 1, 2023
@lahinson
Copy link
Contributor Author

lahinson commented Nov 1, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 1, 2023
@opayne1 opayne1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.14 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 1, 2023
@opayne1 opayne1 added this to the Continuous Release milestone Nov 1, 2023
@opayne1
Copy link
Contributor

opayne1 commented Nov 1, 2023

Looks like this PR will need change management. FYI @JoeAldinger

@opayne1 opayne1 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 1, 2023
@lahinson
Copy link
Contributor Author

lahinson commented Nov 2, 2023

Thanks @opayne1! I'll start this through the change management process.

@xltian
Copy link

xltian commented Nov 2, 2023

Ok to merge the current list, if there are more other known issues, operators not tested, we can update in a separate PR.


* Broadcom network interface controllers in legacy Single Root I/O Virtualization (SR-IOV) do not support quality of service (QoS) and tag protocol identifier (TPID) settings for the SRIOV VLAN. This affects Broadcom BCM57414, Broadcom BCM57508, and Broadcom BCM57504. (link:https://issues.redhat.com/browse/RHEL-9881[*RHEL-9881*])

* In hosted control planes for {product-title}, the following operators and components are not tested (link:https://issues.redhat.com/browse/OCPSTRAT-605[*OCPSTRAT-605*]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* In hosted control planes for {product-title}, the following operators and components are not tested (link:https://issues.redhat.com/browse/OCPSTRAT-605[*OCPSTRAT-605*]):
* In hosted control planes for {product-title}, the following Operators and components are not tested (link:https://issues.redhat.com/browse/OCPSTRAT-605[*OCPSTRAT-605*]):

@lahinson lahinson force-pushed the osdocs-8167-hcp-untested-operators branch from 9eea264 to 62e0c41 Compare November 2, 2023 13:52
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
Copy link

openshift-ci bot commented Nov 2, 2023

New changes are detected. LGTM label has been removed.

@lahinson
Copy link
Contributor Author

lahinson commented Nov 7, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 7, 2023
@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 8, 2023
@xenolinux
Copy link
Contributor

LGTM

I am new on the peer review squad. Please wait until @abhatt-rh gives my review the go-ahead

@xenolinux
Copy link
Contributor

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 8, 2023
Copy link
Contributor

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lahinson. I added a couple of comments related to using common attributes that are available for product names and suggestion about the use of Performance Addon Operator (PAO).


** Performance Addon Operator
** Red Hat OpenShift sandboxed containers
** Red Hat OpenShift GitOps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** Red Hat OpenShift GitOps
** {gitops-title}

** Performance Addon Operator
** Red Hat OpenShift sandboxed containers
** Red Hat OpenShift GitOps
** Red Hat OpenShift Service Mesh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** Red Hat OpenShift Service Mesh
** {SMProductName}

** Red Hat OpenShift sandboxed containers
** Red Hat OpenShift GitOps
** Red Hat OpenShift Service Mesh
** Red Hat OpenShift Pipelines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** Red Hat OpenShift Pipelines
** {pipelines-title}

** Red Hat OpenShift GitOps
** Red Hat OpenShift Service Mesh
** Red Hat OpenShift Pipelines
** Red Hat OpenShift Dev Spaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** Red Hat OpenShift Dev Spaces
** {openshift-dev-spaces-productname}

* In hosted control planes for {product-title}, the following Operators and components are not tested (link:https://issues.redhat.com/browse/OCPSTRAT-605[*OCPSTRAT-605*]):

** Performance Addon Operator
** Red Hat OpenShift sandboxed containers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an attribute for this too: {sandboxed-containers-first}.
However, it resolves in OpenShift sandboxed containers and not Red Hat OpenShift sandboxed containers


* In hosted control planes for {product-title}, the following Operators and components are not tested (link:https://issues.redhat.com/browse/OCPSTRAT-605[*OCPSTRAT-605*]):

** Performance Addon Operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider verifying with the SME if this should be Node Tuning Operator (NTO) instead of the Performance Addon Operator (PAO) since in OCP 4.11, PAO functions moved to NTO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, @abhatt-rh. This reference to Performance Add Operator is correct -- it should not be changed to NTO.

@lahinson lahinson force-pushed the osdocs-8167-hcp-untested-operators branch from 62e0c41 to de0ba8e Compare November 9, 2023 15:40
@lahinson
Copy link
Contributor Author

lahinson commented Nov 9, 2023

Thanks for your review, @abhatt-rh! I replaced the hard-coded names with the attributes that you suggested. I'll move this along to merge review.

@lahinson
Copy link
Contributor Author

lahinson commented Nov 9, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 9, 2023
@abhatt-rh
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 9, 2023
@abhatt-rh abhatt-rh merged commit a7a6d8b into openshift:enterprise-4.14 Nov 9, 2023
@abhatt-rh abhatt-rh removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants