Skip to content

Conversation

Srivaralakshmi
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi commented Nov 22, 2023

Version(s): main only

Issue:

Link to docs preview:
https://68320--docspreview.netlify.app/

SME and QE review: Not applicable

Additional information: This PR updates the _page_openshift.html.erb template file in main for the 1.11 GitOps standalone doc. It does not alter documentation content.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2023
@Srivaralakshmi Srivaralakshmi changed the title RHDEVDOCS-5694 - Update _page_openshift.html.erb [WIP] RHDEVDOCS-5694 - Update _page_openshift.html.erb Nov 22, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2023
@Srivaralakshmi Srivaralakshmi added peer-review-needed Signifies that the peer review team needs to review this PR do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 22, 2023
@GroceryBoyJr
Copy link
Contributor

@GroceryBoyJr removing peer review needed. Review is required from a person who is not on peer review duty this week. There is nothing for peer review team to do on this PR.

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 22, 2023
@Srivaralakshmi Srivaralakshmi removed the request for review from gabriel-rh November 23, 2023 06:56
@Srivaralakshmi Srivaralakshmi added peer-review-needed Signifies that the peer review team needs to review this PR gitops labels Nov 23, 2023
@agantony
Copy link
Contributor

Hi, there is nothing to review in this PR. Perhaps someone from your team can cross-check and merge this PR.

@mramendi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@Srivaralakshmi Srivaralakshmi added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 27, 2023
@shipsing
Copy link
Contributor

shipsing commented Dec 8, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 8, 2023
@shipsing
Copy link
Contributor

shipsing commented Dec 8, 2023

/remove-label do-not-merge/work-in-progress

Copy link

openshift-ci bot commented Dec 8, 2023

@shipsing: The label(s) /remove-label do-not-merge/work-in-progress cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label do-not-merge/work-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak mjpytlak added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 8, 2023
@mjpytlak
Copy link
Contributor

mjpytlak commented Dec 8, 2023

@Srivaralakshmi While the change is small enough, you added your own peer review needed and peer review done labels. Want to confirm that @mramendi is in fact your peer reviewer.

It also appears that your preview is not working. Please generate a preview.

@mramendi
Copy link
Contributor

mramendi commented Dec 8, 2023

I did not notice this PR and got a similar one merged This one should be closed.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mramendi
Copy link
Contributor

mramendi commented Dec 8, 2023

@mjpytlak PRs like this normally don't generate a preview because no doc content is affected, only technical files. In this case, I failed to find this PR and another one with the same content was merged, please close this one (or @Srivaralakshmi can close it when she is online)

@mjpytlak
Copy link
Contributor

mjpytlak commented Dec 8, 2023

Closing at the request of @mramendi

@mjpytlak mjpytlak closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. gitops lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants