Skip to content

[SRVCOM-2658] Add Serverless 1.31 release notes #68620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

[SRVCOM-2658] Add Serverless 1.31 release notes #68620

merged 1 commit into from
Dec 7, 2023

Conversation

rh-max
Copy link
Contributor

@rh-max rh-max commented Nov 30, 2023 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2023
@rh-max rh-max force-pushed the srvls-release-notes-1.31 branch from bb2b4dd to 05b13b5 Compare November 30, 2023 12:08
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 30, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://68620--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/36476

mgencur
mgencur reviewed Nov 30, 2023
View reviewed changes
mgencur
mgencur reviewed Nov 30, 2023
View reviewed changes
jrangelramos
jrangelramos reviewed Nov 30, 2023
View reviewed changes
@briandooley
Copy link
Contributor

@nainaz Can you give this a look?

@mgencur
Copy link
Contributor

mgencur commented Dec 5, 2023

LGTM

@rh-max
Copy link
Contributor Author

rh-max commented Dec 5, 2023

/label serverless
/label peer-review-needed

@openshift-ci openshift-ci bot added serverless Label for all Serverless PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 5, 2023
@skopacz1
Copy link
Contributor

skopacz1 commented Dec 5, 2023

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Dec 5, 2023
skopacz1
skopacz1 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the extra detailed preview links. Also, be sure to squash your commits into one before starting merge review.

@skopacz1
Copy link
Contributor

skopacz1 commented Dec 5, 2023

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2023
@rh-max
Copy link
Contributor Author

rh-max commented Dec 6, 2023

@mgencur Could you PTAL at these new entries suggested by Naina? f2e1157

@skopacz1 Same question, also only about f2e1157

Thanks.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2023
@mgencur
Copy link
Contributor

mgencur commented Dec 6, 2023

LGTM

@rh-max
Copy link
Contributor Author

rh-max commented Dec 7, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 7, 2023
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 7, 2023
jeana-redhat
jeana-redhat reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just left a few questions about some object name type things. If those can be labelled, please do so. When you're ready for merge, please squash commits 🙂

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 7, 2023
@rh-max rh-max force-pushed the srvls-release-notes-1.31 branch from c6d8efb to 9cb49d9 Compare December 7, 2023 14:00
@rh-max
Copy link
Contributor Author

rh-max commented Dec 7, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 7, 2023
jeana-redhat
jeana-redhat approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

/remove-label merge-review-needed

edit to say: will merge and pick as soon as Travis finishes....

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 7, 2023
@jeana-redhat jeana-redhat merged commit 47b1def into openshift:serverless-docs Dec 7, 2023
@jeana-redhat
Copy link
Contributor

/cherrypick serverless-docs-1.31

@jeana-redhat
Copy link
Contributor

/cherrypick serverless-docs-1.30

@openshift-cherrypick-robot
Copy link

@jeana-redhat: #68620 failed to apply on top of branch "serverless-docs-1.31":

Applying: Add Serverless 1.31 release notes
Using index info to reconstruct a base tree...
M	about/serverless-release-notes.adoc
M	modules/release-notes-template.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/release-notes-template.adoc
Auto-merging about/serverless-release-notes.adoc
CONFLICT (content): Merge conflict in about/serverless-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add Serverless 1.31 release notes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick serverless-docs-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 7, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #69072

In response to this:

/cherrypick serverless-docs-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeana-redhat
Copy link
Contributor

@rh-max oddly, this will cherrypick cleanly into 1.30 but not 1.31. I am going to hold off on merging the 1.30 version until things are working right, can you look into the 1.31 issue?

@jeana-redhat
Copy link
Contributor

/cherrypick serverless-docs-1.31

@openshift-cherrypick-robot
Copy link

@jeana-redhat: #68620 failed to apply on top of branch "serverless-docs-1.31":

Applying: Add Serverless 1.31 release notes
Using index info to reconstruct a base tree...
M	about/serverless-release-notes.adoc
M	modules/release-notes-template.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/release-notes-template.adoc
Auto-merging about/serverless-release-notes.adoc
CONFLICT (content): Merge conflict in about/serverless-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add Serverless 1.31 release notes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick serverless-docs-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rh-max rh-max mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat approved these changes

@skopacz1 skopacz1 skopacz1 approved these changes

+2 more reviewers

@mgencur mgencur mgencur left review comments

@jrangelramos jrangelramos jrangelramos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@rh-max @ocpdocs-previewbot @briandooley @mgencur @skopacz1 @jeana-redhat @openshift-cherrypick-robot @jrangelramos