Skip to content

PR for SRVKS-1092: Wrong code block format used in the document #70013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2024
Merged

PR for SRVKS-1092: Wrong code block format used in the document #70013

merged 1 commit into from
Feb 2, 2024

Conversation

kaldesai
Copy link

@kaldesai kaldesai commented Jan 10, 2024 •
edited
Loading

Affected cherry-picking versions:

  • serverless-docs 1.29
  • serverless-docs 1.30
  • serverless-docs 1.31
  • serverless-docs 1.32

Associated JIRA: https://issues.redhat.com/browse/SRVKS-1092?src=confmacro

Doc preview and description:

Check the following sections I have removed the unnecessary code block that was added.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 10, 2024 •
edited by openshift-ci bot
Loading

@kaldesai: This pull request references SRVKS-1092 which is a valid jira issue.

In response to this:

Associated JIRA: https://issues.redhat.com/browse/SRVKS-1092?src=confmacro

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 10, 2024
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 10, 2024 •
edited
Loading

🤖 Updated build preview is available at:
https://70013--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37335

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 10, 2024 •
edited by openshift-ci bot
Loading

@kaldesai: This pull request references SRVKS-1092 which is a valid jira issue.

In response to this:

Affected cherry-picking versions:

  • serverless-docs 1.29
  • serverless-docs 1.30
  • serverless-docs 1.31
  • serverless-docs 1.32

Associated JIRA: https://issues.redhat.com/browse/SRVKS-1092?src=confmacro

Doc preview and description:

Check the following sections I have removed the unnecessary code block that was added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nak3
Copy link
Contributor

nak3 commented Jan 18, 2024

/lgtm

Thank you!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@mgencur
Copy link
Contributor

mgencur commented Jan 24, 2024

LGTM

@kaldesai kaldesai changed the title WIP PR for SRVKS-1092: Wrong code block format used in the document PR for SRVKS-1092: Wrong code block format used in the document Jan 31, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@kaldesai kaldesai force-pushed the SRVKS-1092-Serverless branch from 6d8bcd2 to b190bd6 Compare January 31, 2024 06:00
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 31, 2024

New changes are detected. LGTM label has been removed.

@kaldesai
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 31, 2024
@Srivaralakshmi Srivaralakshmi added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 31, 2024
Srivaralakshmi
Srivaralakshmi reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaldesai Neat PR! LGTM. Thank you!

As I am new to the peer review squad, I would ask @bmcelvee to give my review the go-ahead. Please wait until Brandi applies the peer-review-done label.

@Srivaralakshmi Srivaralakshmi added serverless Label for all Serverless PRs lgtm Indicates that a PR is ready to be merged. labels Jan 31, 2024
@kaldesai
Copy link
Author

kaldesai commented Feb 1, 2024

@bmcelvee can you please verify and ack my PR? @Srivaralakshmi has alredy completed the peer review. Thank you!

@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 1, 2024
@bmcelvee
Copy link
Contributor

bmcelvee commented Feb 1, 2024

LGTM!

@kaldesai
Copy link
Author

kaldesai commented Feb 2, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 2, 2024
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 2, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone Feb 2, 2024
@mburke5678 mburke5678 merged commit b088000 into openshift:serverless-docs Feb 2, 2024
@mburke5678
Copy link
Contributor

/cherrypick serverless-docs-1.29

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #71118

In response to this:

/cherrypick serverless-docs-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 2, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: cannot checkout serverless-docs 1.30: error checking out "serverless-docs 1.30": exit status 1 error: pathspec 'serverless-docs 1.30' did not match any file(s) known to git

In response to this:

/cherrypick serverless-docs 1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick serverless-docs-1.30

@mburke5678
Copy link
Contributor

/cherrypick serverless-docs-1.31

@mburke5678
Copy link
Contributor

/cherrypick serverless-docs-1.32

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #71119

In response to this:

/cherrypick serverless-docs-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 2, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #71120

In response to this:

/cherrypick serverless-docs-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 2, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: cannot checkout serverless-docs-1.32: error checking out "serverless-docs-1.32": exit status 1 error: pathspec 'serverless-docs-1.32' did not match any file(s) known to git

In response to this:

/cherrypick serverless-docs-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

@kaldesai I got this error: 'serverless-docs-1.32' did not match any file(s) known to git. Is this expected?

@kaldesai
Copy link
Author

kaldesai commented Feb 6, 2024

@kaldesai I got this error: 'serverless-docs-1.32' did not match any file(s) known to git. Is this expected?

I think so, as I am unable to see the 'serverless-docs-1.32' branch in the repository. I will let you know about the same. Thank you so much for merging the PR for the rest all the branches. :)

@kaldesai
Copy link
Author

kaldesai commented Feb 7, 2024

@mburke5678
The serverless-docs-1.32 branch is now created. Can you please cherry-pick this PR content for that branch? Thank you so much in advance!

@kaldesai
Copy link
Author

@mburke5678
The serverless-docs-1.32 branch is now created. Can you please cherry-pick this PR content for that branch? Thank you!

@mburke5678
Copy link
Contributor

/cherrypick serverless-docs-1.32

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request could not be created: failed to create pull request against openshift/openshift-docs#serverless-docs-1.32 from head openshift-cherrypick-robot:cherry-pick-70013-to-serverless-docs-1.32: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:serverless-docs-1.32 and openshift-cherrypick-robot:cherry-pick-70013-to-serverless-docs-1.32"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick serverless-docs-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Srivaralakshmi Srivaralakshmi Srivaralakshmi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nak3 nak3

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@kaldesai @openshift-ci-robot @ocpdocs-previewbot @nak3 @mgencur @bmcelvee @mburke5678 @openshift-cherrypick-robot @Srivaralakshmi