-
Notifications
You must be signed in to change notification settings - Fork 1.8k
WIP PR for SRVLOGIC-209: Add the "Openshift Serverless Logic overview" section. #70393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP PR for SRVLOGIC-209: Add the "Openshift Serverless Logic overview" section. #70393
Conversation
@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue Mar 05 08:59:52 - Prow CI generated the docs preview: |
…gic getting started directory
…g started directory
@kaldesai, Please add relevant files that are part of your topic map so that all checks passed. |
…serverless logic assemblies in the respected directories
…s for demo purpose
@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This pull request has been repointed to target serverless-docs-main. serverless-docs is no longer in use. |
@kaldesai: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the overview section, seems a bit different from https://openshift-knative.github.io/docs/docs/latest/serverless-logic/about.html probably needs updating. I added suggestions before I compared so feel free to ignore those.
|
||
toc::[] | ||
|
||
OpenShift Serverless Logic enables developers or architects to define declarative workflow models that orchestrate event-driven, serverless applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenShift Serverless Logic enables developers or architects to define declarative workflow models that orchestrate event-driven, serverless applications. | |
OpenShift Serverless Logic enables developers or architects to create cloud-native applications using declarative workflow models that orchestrate event-driven, serverless applications. |
nitpick, kind of missing the notion of cloudnativeapps, with my suggestion it feels too long thought so I am not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the original text here is good, because it introduces the main concept of "workflows" to do, bla, bla.
|
||
OpenShift Serverless Logic enables developers or architects to define declarative workflow models that orchestrate event-driven, serverless applications. | ||
|
||
OpenShift Serverless Logic is also designed to write workflows in formats (JSON or YAML) that might be better suited for developing and deploying serverless applications in cloud or container environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenShift Serverless Logic is also designed to write workflows in formats (JSON or YAML) that might be better suited for developing and deploying serverless applications in cloud or container environments. | |
OpenShift Serverless Logic allows users to define workflows in formats (JSON or YAML) that are well suited for developing and deploying serverless applications in cloud or container environments. |
wdyt?
|
||
OpenShift Serverless Logic is also designed to write workflows in formats (JSON or YAML) that might be better suited for developing and deploying serverless applications in cloud or container environments. | ||
|
||
For OpenShift Serverless Logic implementation, you can use the Kubernetes operator to deploy the workflow models using Knative. Knative Eventing plays an important role and provides the essential infrastructure for event-driven architectures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For OpenShift Serverless Logic implementation, you can use the Kubernetes operator to deploy the workflow models using Knative. Knative Eventing plays an important role and provides the essential infrastructure for event-driven architectures. | |
OpenShift Serverless Logic provides the Kubernetes operator to deploy & manage the workflow models using Knative. Knative Eventing plays an important role and provides the essential infrastructure for event-driven architectures. |
Small suggestion, let me know.
We should also mentions serving somehow imho.
Lastly, from user perspective it did not tell me much, if we are talking overview I think it could be expanded slightly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can say something like this:
OpenShift Serverless Logic provides the Kubernetes operator to deploy & manage the workflow models using Knative Serving or Kubernetes deployments. And, Knative Eventing provides the essential infrastructure for event-driven architectures.
Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-209
Doc preview for Serverless Logic sections