Skip to content

Conversation

kaldesai
Copy link

@kaldesai kaldesai commented Jan 17, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024

@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue.

In response to this:

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-209

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 17, 2024

🤖 Tue Mar 05 08:59:52 - Prow CI generated the docs preview:
https://70393--ocpdocs-pr.netlify.app

@shipsing
Copy link
Contributor

@kaldesai, Please add relevant files that are part of your topic map so that all checks passed.
This is the error:
image

@kaldesai
Copy link
Author

@shipsing

I have added the file names in the topic map file as follows:
image

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2024

@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue.

In response to this:

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-209

Doc preview for Serverless Logic sections

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aireilly aireilly changed the base branch from serverless-docs to serverless-docs-main March 5, 2024 08:55
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue.

In response to this:

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-209

Doc preview for Serverless Logic sections

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aireilly
Copy link
Contributor

aireilly commented Mar 5, 2024

This pull request has been repointed to target serverless-docs-main. serverless-docs is no longer in use.

Copy link

openshift-ci bot commented Mar 5, 2024

@kaldesai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc 6b7da23 link true /test validate-asciidoc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the overview section, seems a bit different from https://openshift-knative.github.io/docs/docs/latest/serverless-logic/about.html probably needs updating. I added suggestions before I compared so feel free to ignore those.


toc::[]

OpenShift Serverless Logic enables developers or architects to define declarative workflow models that orchestrate event-driven, serverless applications.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OpenShift Serverless Logic enables developers or architects to define declarative workflow models that orchestrate event-driven, serverless applications.
OpenShift Serverless Logic enables developers or architects to create cloud-native applications using declarative workflow models that orchestrate event-driven, serverless applications.

nitpick, kind of missing the notion of cloudnativeapps, with my suggestion it feels too long thought so I am not sure.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the original text here is good, because it introduces the main concept of "workflows" to do, bla, bla.


OpenShift Serverless Logic enables developers or architects to define declarative workflow models that orchestrate event-driven, serverless applications.

OpenShift Serverless Logic is also designed to write workflows in formats (JSON or YAML) that might be better suited for developing and deploying serverless applications in cloud or container environments.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OpenShift Serverless Logic is also designed to write workflows in formats (JSON or YAML) that might be better suited for developing and deploying serverless applications in cloud or container environments.
OpenShift Serverless Logic allows users to define workflows in formats (JSON or YAML) that are well suited for developing and deploying serverless applications in cloud or container environments.

wdyt?


OpenShift Serverless Logic is also designed to write workflows in formats (JSON or YAML) that might be better suited for developing and deploying serverless applications in cloud or container environments.

For OpenShift Serverless Logic implementation, you can use the Kubernetes operator to deploy the workflow models using Knative. Knative Eventing plays an important role and provides the essential infrastructure for event-driven architectures.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For OpenShift Serverless Logic implementation, you can use the Kubernetes operator to deploy the workflow models using Knative. Knative Eventing plays an important role and provides the essential infrastructure for event-driven architectures.
OpenShift Serverless Logic provides the Kubernetes operator to deploy & manage the workflow models using Knative. Knative Eventing plays an important role and provides the essential infrastructure for event-driven architectures.

Small suggestion, let me know.
We should also mentions serving somehow imho.
Lastly, from user perspective it did not tell me much, if we are talking overview I think it could be expanded slightly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can say something like this:

OpenShift Serverless Logic provides the Kubernetes operator to deploy & manage the workflow models using Knative Serving or Kubernetes deployments. And, Knative Eventing provides the essential infrastructure for event-driven architectures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants