-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Logging 5.6.16 Release Notes #71234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging 5.6.16 Release Notes #71234
Conversation
🤖 Tue Feb 06 01:26:45 - Prow CI generated the docs preview: https://71234--ocpdocs-pr.netlify.app |
@libander: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
/label peer-review-needed |
CVE-2023-39326 needs to be added under CVE list here as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what branches are you trying to apply this to? I see that commit is against the 4.13 branch, but that you indicate that you want to apply it to 4.13, 4.12, and 4.11.
4.12 and 4.11 can be CP'd after it merges. |
/label merge-review-needed |
@libander, I need more data before you can have blanket approval for CPs off branches other than main. This one looks like it should be fine to attempt. |
@libander I understand that your releases are live, so I am going to get this merged up. However, you effectively have an orphaned heading with CVE. [1] I understand that the only CVE that shipped was private/internal. Please double back on this with a separate PR to add text about no CVEs shipping with this release. As it stands, customers might be confused and think that references are missing. |
/cherrypick enterprise-4.12 |
@mjpytlak: new pull request created: #71351 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.11 |
@mjpytlak: new pull request created: #71352 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.13, 4.12, 4.11
Issue: OBSDOCS-776
Link to docs preview:
QE review: @anpingli / @QiaolingTang / @kabirbhartiRH
Additional information:
SME Review: @jcantrill / @xperimental / @alanconway / @periklis