Skip to content

Conversation

libander
Copy link
Contributor

@libander libander commented Feb 6, 2024

Version(s): 4.13, 4.12, 4.11

Issue: OBSDOCS-776

Link to docs preview:

QE review: @anpingli / @QiaolingTang / @kabirbhartiRH

  • QE has approved this change.

Additional information:
SME Review: @jcantrill / @xperimental / @alanconway / @periklis

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2024
@ocpdocs-previewbot
Copy link

🤖 Tue Feb 06 01:26:45 - Prow CI generated the docs preview: https://71234--ocpdocs-pr.netlify.app

Copy link

openshift-ci bot commented Feb 6, 2024

@libander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anpingli
Copy link

anpingli commented Feb 7, 2024

LGTM

@libander
Copy link
Contributor Author

libander commented Feb 7, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 7, 2024
@kabirbhartiRH
Copy link

CVE-2023-39326 needs to be added under CVE list here as well.

@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 7, 2024
@lpettyjo lpettyjo self-requested a review February 7, 2024 18:17
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 7, 2024
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what branches are you trying to apply this to? I see that commit is against the 4.13 branch, but that you indicate that you want to apply it to 4.13, 4.12, and 4.11.

@libander
Copy link
Contributor Author

libander commented Feb 7, 2024

Also, what branches are you trying to apply this to? I see that commit is against the 4.13 branch, but that you indicate that you want to apply it to 4.13, 4.12, and 4.11.

4.12 and 4.11 can be CP'd after it merges.

@libander
Copy link
Contributor Author

libander commented Feb 7, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 7, 2024
@kalexand-rh
Copy link
Contributor

@libander, I need more data before you can have blanket approval for CPs off branches other than main. This one looks like it should be fine to attempt.

@mjpytlak mjpytlak added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 8, 2024
@mjpytlak
Copy link
Contributor

mjpytlak commented Feb 8, 2024

@libander I understand that your releases are live, so I am going to get this merged up. However, you effectively have an orphaned heading with CVE. [1] I understand that the only CVE that shipped was private/internal. Please double back on this with a separate PR to add text about no CVEs shipping with this release. As it stands, customers might be confused and think that references are missing.

[1] https://71234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/logging_release_notes/logging-5-6-release-notes#logging-release-notes-5-6-16-CVEs

@mjpytlak mjpytlak merged commit 0a7d539 into openshift:enterprise-4.13 Feb 8, 2024
@mjpytlak
Copy link
Contributor

mjpytlak commented Feb 8, 2024

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@mjpytlak: new pull request created: #71351

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak
Copy link
Contributor

mjpytlak commented Feb 8, 2024

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@mjpytlak: new pull request created: #71352

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants