Skip to content

RHDEVDOCS-5795: Correct typo gitops tables #71280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3,859 commits into from
Closed

RHDEVDOCS-5795: Correct typo gitops tables #71280

wants to merge 3,859 commits into from

Conversation

nebelsprachen
Copy link

@nebelsprachen nebelsprachen commented Feb 7, 2024 •
edited
Loading

• Aligned team: Dev Tools
• Please cherry-pick to: gitops-docs-1.10 gitops-docs-1.11

Version(s):

gitops-docs-1.11, gitops-docs-1.10

Issue:

RHDEVDOCS#5795

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

SNiemann15 and others added 30 commits January 23, 2024 15:09
@SNiemann15
change master/worker to control plane/compute
df89a17
@dfitzmau
OCPBUGS#26565: Expanded the FIPS cryptography mode note with RHEL 9 c…
d03f48d 
…lause
@rohennes
OCPBUGS-18605: Replacing host name with generic host name
c610cf6
@mjpytlak
OSDOCS#8474: Bump version in link to ARM template for network and loa…
ca84889 
…d balancers
@bergerhoffer
OSDOCS#8967: Doc set sweep to change 1.27 to 1.28
a155c91
@abrennan89
Merge pull request openshift#70592 from abrennan89/OBSDOCS-125
44cc6bb 
OBSDOCS-125: Update callouts to clarify log collection behavior
@rh-tokeefe
OSSM-5786: Extend cleanup commands about ossm-cni resources
77e810f
@bergerhoffer
Merge pull request openshift#69920 from bergerhoffer/OSDOCS-8967
232e611 
OSDOCS#8967: Doc set sweep to change 1.27 to 1.28
@ShaunaDiaz
OSDOCS-9408: update FIPS in install MicroShift
129cd1b
@JoeAldinger
Merge pull request openshift#62001 from jmanthei/OCPBUGS-13925
694088f 
/lgtm OCPBUGS-13925 add flags to collect podman logs
clarified storage profile customizations reqts
3e5cc93
@sjhala-ccs
Merge pull request openshift#70630 from sjhala-ccs/cnv-27696
8f2578b 
CNV-27696: Created dummy release notes files
@sr1kar99
Resolved conflicts
733c034
@alokstech @ShaunaDiaz
Adding a note for the eventrouter image
5717dc3 
Adding a note for the eventrouter image not being a part of the cluster-logging operator.

Adding a note for the eventrouter image

Adding a note for the eventrouter image

Update modules/cluster-logging-eventrouter-deploy.adoc

Co-authored-by: Shauna Diaz <shdiaz@redhat.com>
@SNiemann15
OCPBUGS27224 change vmname to hostname and brackets
50a74df
@kquinn1204
OCPBUGS-26172 configuring the master interface in the container netwo…
b7c3705 
…rk namespace example2
@ShaunaDiaz
Merge pull request openshift#70567 from ShaunaDiaz/OSDOCS-9408
ffdfa6a 
OSDOCS-9408: update FIPS in install MicroShift
@aravipra
OSDOCS-8804: Adding the MicroShift service to a blueprint section is …
0fa1192 
…modified for microshift
@smunje1
OSDOCS-9070
82c982a
@JoeAldinger
Merge pull request openshift#69785 from aspauldi/CNV-33431
1320ba8 
/lgtm, merging CNV-33431: Storage profile must be reapplied if storage class changes
@stevsmit
Merge pull request openshift#70557 from SNiemann15/ibmz_multiarch_com…
25b174e 
…pute

OCPBUGS-27224 Change vmname to hostname and variable bracket format
@ShaunaDiaz
Merge pull request openshift#70554 from aravipra/OSDOCS-8804
24b5496 
OSDOCS-8804: Adding the MicroShift service to a blueprint section is …
@bergerhoffer
Merge pull request openshift#69965 from kquinn1204/OCPBUGS-26172
529c881 
OCPBUGS-26172 Configuring the master interface in the container network namespace with master bridge interface
@mjpytlak
Merge pull request openshift#70683 from mjpytlak/osdocs-8474
d067aff 
OSDOCS#8474: Bump version in  link to ARM template for network and lo…
@xJustin
OSDOCS-8388 Deploying an App Prereqs
f52265a
Added attribute guideline
8016d78
@JoeAldinger
Merge pull request openshift#69136 from rohennes/TELCODOCS-420
11909a1 
/lgtm TELCODOCS-420: Adding new metrics for MetalLB
Changed the sequence of user-defined tags
08a391a
@bergerhoffer
Merge pull request openshift#70432 from mjahoda/tang-operator-OCPBUGS…
cc6b568 
…-25998

Fix the channel value for tang-operator
@bergerhoffer
OSDOCS#8969: Restructuring docs for the descheduler operator being async
220c08b
mjpytlak and others added 10 commits February 6, 2024 09:41
@mjpytlak
Merge pull request openshift#71230 from mjpytlak/osdocs-9566
d1feb04 
OSDOCS#9566: Removing Assisted Installer references from failure doma…
@jeana-redhat
Merge pull request openshift#70909 from xJustin/OSDOCS-9364-ROSA-stor…
c068b67 
…age-options

OSDOCS-9364 updated ROSA PV Storage options
@mjpytlak
Merge pull request openshift#70463 from CarmiWisemon/mig1512-mtc18-su…
72e2c96 
…pports-ocp4migration

MIG 1512 - MTC 1.8 only supports OCP4->4 migrations
@jldohmann
OSDOCS-9369: add improved mco status updates tech preview
36ca80c
ifeval-vsphere-quickfix: removes vsphere
adb3c3b
@jldohmann
Merge pull request openshift#70593 from jldohmann/OSDOCS-9369
01bb9e3 
OSDOCS-9369: add improved mco status updates tech preview
@JoeAldinger
Merge pull request openshift#71261 from JoeAldinger/ifeval-vsphere-qu…
eb39682 
…ickfix

/lgtm ifeval-vsphere-quickfix: removes vsphere
@abrennan89
OBSDOCS-760: Update structure of resource scheduling docs
c089ee6
@abrennan89
Merge pull request openshift#70879 from abrennan89/scheduling
4422bfc 
OBSDOCS-760: Update structure of resource scheduling docs
update instances of disableAdmin
6a8af80
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 7, 2024 •
edited
Loading

🤖 Wed Feb 07 09:27:22 - Prow CI generated the docs preview: https://71280--ocpdocs-pr.netlify.app

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2024
@nebelsprachen nebelsprachen changed the title Correct typo for nstances of disableAdmin RHDEVDOCS-5795: Correct typo gitops tables Feb 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2024 •
edited by openshift-ci bot
Loading

@joaedwar: This pull request references RHDEVDOCS-5795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

RHDEVDOCS#5795

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 7, 2024

@joaedwar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2024 •
edited by openshift-ci bot
Loading

@joaedwar: This pull request references RHDEVDOCS-5795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

gitops-docs-1.11, gitops-docs-1.10

Issue:

RHDEVDOCS#5795

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2024 •
edited by openshift-ci bot
Loading

@joaedwar: This pull request references RHDEVDOCS-5795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

• Aligned team: Dev Tools
• Please cherry-pick to: gitops-docs-1.10 gitops-docs-1.11

Version(s):

gitops-docs-1.11, gitops-docs-1.10

Issue:

RHDEVDOCS#5795

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2024 •
edited by openshift-ci bot
Loading

@joaedwar: This pull request references RHDEVDOCS-5795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

• Aligned team: Dev Tools
• Please cherry-pick to: gitops-docs-1.10 gitops-docs-1.11

Version(s):

gitops-docs-1.11, gitops-docs-1.10

Issue:

RHDEVDOCS#5795

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor

eromanova97 commented Feb 13, 2024 •
edited
Loading

Hello @joaedwar I cannot open the preview. I tried to find a reason and I realized that the PR is marked to be merged into openshift:main instead of openshift:gitops-docs which I think might be causing the issue.
I am not sure how that can be changed or if the PR will have to be raised again, please let me know and I will review it then, thank you!

Edit: it seems it can be done, here is the guide: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request
please let me know once it is changed, thank you! 🙂

@nebelsprachen nebelsprachen changed the base branch from main to gitops-docs February 14, 2024 10:18
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2024 •
edited by openshift-ci bot
Loading

@joaedwar: This pull request references RHDEVDOCS-5795 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• Please cherry-pick to: gitops-docs-1.10 gitops-docs-1.11

Version(s):

gitops-docs-1.11, gitops-docs-1.10

Issue:

RHDEVDOCS#5795

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.