Skip to content

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Feb 8, 2024

Version(s):

GitOps 1.11

Versions for cherry-picking: GitOps 1.8, 1.9, 1.10, 1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

https://71331--docspreview.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations

Initial peer review: @shipsing
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

…ntent

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2024
Copy link

openshift-ci bot commented Feb 8, 2024

Hi @Dhruv-Soni11. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.11

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

Initial peer review: @eromanova97
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

Initial peer review: @eromanova97
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.11

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

Initial peer review: @eromanova97
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.11

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

Initial peer review: @eromanova97
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 8, 2024

🤖 Updated build preview is available at:
https://71331--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37583

@Dhruv-Soni11 Dhruv-Soni11 changed the title RHDEVDOCS-5857: Changing incorrect attribute [gitops-title] in the co… WIP: RHDEVDOCS-5857: Changing incorrect attribute [gitops-title] in the co… Feb 8, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.11

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

https://71331--docspreview.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations

Initial peer review: @eromanova97
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Dhruv-Soni11
Copy link
Contributor Author

Dhruv-Soni11 commented Feb 8, 2024

/label peer-review-needed

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.11

Versions for cherry-picking: 1.8, 1.9, 1.10

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

https://71331--docspreview.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations

Initial peer review: @eromanova97
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.11

Versions for cherry-picking: 1.8, 1.9, 1.10

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

https://71331--docspreview.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations

Initial peer review: @shipsing
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.11

Versions for cherry-picking: GitOps 1.8, 1.9, 1.10

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

https://71331--docspreview.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations

Initial peer review: @shipsing
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Srivaralakshmi
Copy link
Contributor

@Dhruv-Soni11 LGTM too :)

@Dhruv-Soni11 Dhruv-Soni11 changed the title WIP: RHDEVDOCS-5857: Changing incorrect attribute [gitops-title] in the co… RHDEVDOCS-5857: Changing incorrect attribute [gitops-title] in the co… Feb 19, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2024
@varshab1210
Copy link

LGTM, thanks

@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

Copy link

openshift-ci bot commented Feb 19, 2024

@Dhruv-Soni11: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dhruv-Soni11
Copy link
Contributor Author

/remove-label peer-review-needed

Copy link

openshift-ci bot commented Feb 19, 2024

@Dhruv-Soni11: Those labels are not set on the issue: peer-review-needed

In response to this:

/remove-label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.11

Versions for cherry-picking: GitOps 1.8, 1.9, 1.10

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5857

Link to docs preview:

https://71331--docspreview.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations

Initial peer review: @shipsing
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@adellape adellape added the dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs label Feb 21, 2024
@adellape adellape added this to the Continuous Release milestone Feb 21, 2024
@adellape adellape added gitops and removed dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Feb 21, 2024
@Srivaralakshmi
Copy link
Contributor

It looks like there was a peer review done on this, however I don't see the peer-review-done label on the PR. But either way, I have a formatting question that I'd like to pause merge for.

Please re-queue for merge-review when addressed. Thank you!

@adellape My bad, missed the peer-review-done label and backtick. thanks for the catch.
@Dhruv-Soni11 Please address the comments.

Thank you!

Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 out of scope comments added for a potential follow-up PR, but not blocking merge for them.

@adellape adellape merged commit 85ee0c4 into openshift:gitops-docs Feb 27, 2024
@adellape
Copy link
Contributor

/cherrypick gitops-docs-1.11

@adellape
Copy link
Contributor

/cherrypick gitops-docs-1.10

@adellape
Copy link
Contributor

/cherrypick gitops-docs-1.9

@adellape
Copy link
Contributor

/cherrypick gitops-docs-1.8

@openshift-cherrypick-robot

@adellape: new pull request created: #72156

In response to this:

/cherrypick gitops-docs-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #72157

In response to this:

/cherrypick gitops-docs-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #72158

In response to this:

/cherrypick gitops-docs-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #72159

In response to this:

/cherrypick gitops-docs-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 28, 2024
@adellape adellape removed the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 28, 2024
@adellape
Copy link
Contributor

/cherrypick gitops-docs-1.12

@openshift-cherrypick-robot

@adellape: new pull request created: #72293

In response to this:

/cherrypick gitops-docs-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitops jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants