-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-5857: Changing incorrect attribute [gitops-title] in the co… #71331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hi @Dhruv-Soni11. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37583 |
02092eb
to
c8eaa05
Compare
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-needed |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
modules/gitops-using-argo-cd-instance-to-manage-cluster-scoped-resources.adoc
Outdated
Show resolved
Hide resolved
@Dhruv-Soni11 LGTM too :) |
LGTM, thanks |
/label merge-review-needed |
@Dhruv-Soni11: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-label peer-review-needed |
@Dhruv-Soni11: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5857 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@adellape My bad, missed the peer-review-done label and backtick. thanks for the catch. Thank you! |
c8eaa05
to
4654ed9
Compare
modules/gitops-using-argo-cd-instance-to-manage-cluster-scoped-resources.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 out of scope comments added for a potential follow-up PR, but not blocking merge for them.
modules/gitops-using-argo-cd-instance-to-manage-cluster-scoped-resources.adoc
Show resolved
Hide resolved
modules/gitops-using-argo-cd-instance-to-manage-cluster-scoped-resources.adoc
Show resolved
Hide resolved
/cherrypick gitops-docs-1.11 |
/cherrypick gitops-docs-1.10 |
/cherrypick gitops-docs-1.9 |
/cherrypick gitops-docs-1.8 |
@adellape: new pull request created: #72156 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adellape: new pull request created: #72157 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adellape: new pull request created: #72158 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adellape: new pull request created: #72159 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label merge-review-needed |
/cherrypick gitops-docs-1.12 |
@adellape: new pull request created: #72293 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…
Version(s):
GitOps 1.11
Versions for cherry-picking: GitOps 1.8, 1.9, 1.10, 1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5857
Link to docs preview:
https://71331--docspreview.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations
Initial peer review: @shipsing
Peer review: @Srivaralakshmi
SME review: @reginapizza
QE review: @varshab1210
Additional information: