Skip to content

OSDOCS-8914: Explaining upgrades for ROSA with HCP clusters. #71393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2024
Merged

OSDOCS-8914: Explaining upgrades for ROSA with HCP clusters. #71393

merged 1 commit into from
Feb 21, 2024

Conversation

EricPonvelle
Copy link
Contributor

Version(s):
enterprise-4.14+

Issue:
OSDOCS-8914

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Elaborating on the various ways to update ROSA with HCP clusters.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024 •
edited by openshift-ci bot
Loading

@EricPonvelle: This pull request references OSDOCS-8914 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.14+

Issue:
OSDOCS-8914

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Elaborating on the various ways to update ROSA with HCP clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 8, 2024 •
edited
Loading

🤖 Tue Feb 20 22:10:57 - Prow CI generated the docs preview: https://71393--ocpdocs-pr.netlify.app

@EricPonvelle EricPonvelle force-pushed the OSDOCS-8914_HCP-Upgrades branch from c92434c to ac5a358 Compare February 8, 2024 20:55
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2024
@EricPonvelle EricPonvelle force-pushed the OSDOCS-8914_HCP-Upgrades branch 3 times, most recently from a6faa1a to 2b44928 Compare February 8, 2024 21:48
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2024
@EricPonvelle EricPonvelle force-pushed the OSDOCS-8914_HCP-Upgrades branch 5 times, most recently from ad57d01 to f270b74 Compare February 9, 2024 16:23
AedinC
AedinC reviewed Feb 9, 2024
View reviewed changes
AedinC
AedinC reviewed Feb 9, 2024
View reviewed changes
AedinC
AedinC reviewed Feb 9, 2024
View reviewed changes
@EricPonvelle EricPonvelle force-pushed the OSDOCS-8914_HCP-Upgrades branch from f270b74 to ea5f797 Compare February 9, 2024 17:07
jneczypor
jneczypor reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@jneczypor jneczypor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried my best to capture the sentiments of the SRE. Good luck!

@EricPonvelle EricPonvelle force-pushed the OSDOCS-8914_HCP-Upgrades branch from ea5f797 to 269ac7a Compare February 9, 2024 21:26
andreadecorte
andreadecorte reviewed Feb 12, 2024
View reviewed changes
modules/rosa-hcp-upgrading-cli-tutorial.adoc Outdated
// +
// [source,terminal]
// ----
// $ rosa upgrade cluster -c <cluster_name> [--schedule-date=XX --schedule-time=XX] [--version 4.14.8]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned, this doesn't exist at the moment, I assume the // means commented out, so not appearing in the published doc right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I can totally remove it if we want to publish the rest of the updates until this is ready, but right now, it's totally hidden.

andreadecorte
andreadecorte reviewed Feb 12, 2024
View reviewed changes
@andreadecorte
Copy link

There was also a discussion about the version skew between control plane and machine pool that can only be 2 minor versions, we should mention this also somewhere.
E.g. 4.16.x control plane can support 4.14.x node pools, but not 4.13.x node pools.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-8914_HCP-Upgrades branch from 269ac7a to 5302c24 Compare February 12, 2024 16:12
@EricPonvelle
Copy link
Contributor Author

@andreadecorte Would a note like this work?

image

@EricPonvelle EricPonvelle force-pushed the OSDOCS-8914_HCP-Upgrades branch from 5302c24 to 20d46e0 Compare February 20, 2024 14:17
@andreadecorte
Copy link

lgtm

radtriste
radtriste approved these changes Feb 20, 2024
View reviewed changes
Copy link

@radtriste radtriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@EricPonvelle EricPonvelle force-pushed the OSDOCS-8914_HCP-Upgrades branch 3 times, most recently from 7165b5e to 8a3e399 Compare February 20, 2024 17:14
@EricPonvelle EricPonvelle added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 20, 2024
@skopacz1
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 20, 2024
skopacz1
skopacz1 reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments but otherwise LGTM

@skopacz1
Copy link
Contributor

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 20, 2024
@EricPonvelle EricPonvelle force-pushed the OSDOCS-8914_HCP-Upgrades branch from 8a3e399 to ed7dd71 Compare February 20, 2024 22:03
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 20, 2024

@EricPonvelle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EricPonvelle EricPonvelle added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 20, 2024
@bscott-rh
Copy link
Contributor

Merge review LGTM.

@bscott-rh bscott-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 21, 2024
@bscott-rh bscott-rh added this to the Continuous Release milestone Feb 21, 2024
@bscott-rh bscott-rh merged commit 8c2feea into openshift:main Feb 21, 2024
@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 21, 2024
Merged
@openshift-cherrypick-robot
Copy link

@bscott-rh: new pull request created: #71939

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@bscott-rh: new pull request created: #71940

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 21, 2024
Merged
@EricPonvelle EricPonvelle deleted the OSDOCS-8914_HCP-Upgrades branch February 21, 2024 13:31
aireilly pushed a commit to aireilly/openshift-docs that referenced this pull request Feb 21, 2024
@bscott-rh @aireilly
Merge pull request openshift#71393 from EricPonvelle/OSDOCS-8914_HCP-…
e5e5c58 
…Upgrades

OSDOCS-8914: Explaining upgrades for ROSA with HCP clusters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skopacz1 skopacz1 skopacz1 left review comments

@jneczypor jneczypor jneczypor left review comments

+3 more reviewers

@andreadecorte andreadecorte andreadecorte left review comments

@AedinC AedinC AedinC left review comments

@radtriste radtriste radtriste approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
10 participants
@EricPonvelle @openshift-ci-robot @ocpdocs-previewbot @andreadecorte @skopacz1 @bscott-rh @openshift-cherrypick-robot @radtriste @AedinC @jneczypor