OSDOCS#9736: Agent 4.15 feature RNs #71931

skopacz1 · 2024-02-20T21:29:25Z

OSDOCS-9736

Version(s): 4.15

QE review:

QE has approved this change.

Preview:

openshift-ci-robot · 2024-02-20T21:29:29Z

@skopacz1: This pull request references OSDOCS-9736 which is a valid jira issue.

In response to this:

OSDOCS-9736

Version(s): 4.15

QE review:

QE has approved this change.

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

skopacz1 · 2024-02-20T21:30:50Z

@mhanss can you PTAL when you have a chance? I'm also not sure whether or not to mention AGENT-704 since the docs for this aren't added to our regular OCP docs, but I can add a section for it if you'd like. Thanks!

ocpdocs-previewbot · 2024-02-20T21:33:41Z

🤖 Wed Feb 21 20:21:12 - Prow CI generated the docs preview: https://71931--ocpdocs-pr.netlify.app

bmanzari · 2024-02-21T07:46:33Z

/lgtm

openshift-ci-robot · 2024-02-21T18:05:11Z

@skopacz1: This pull request references OSDOCS-9736 which is a valid jira issue.

In response to this:

OSDOCS-9736

Version(s): 4.15

QE review:

QE has approved this change.

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

skopacz1 · 2024-02-21T18:27:50Z

@bmanzari Thanks so much for helping with QE review!!

openshift-ci-robot · 2024-02-21T18:28:03Z

@skopacz1: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

OSDOCS-9736

Version(s): 4.15

QE review:

QE has approved this change.

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

skopacz1 · 2024-02-21T18:34:01Z

/label peer-review-needed

bscott-rh

Two small nits, otherwise LGTM.

/remove-label peer-review-in-progress
/label peer-review-done

bscott-rh · 2024-02-21T20:03:54Z

release_notes/ocp-4-15-release-notes.adoc

+For more information, see xref:../installing/installing_with_agent_based_installer/installation-config-parameters-agent.adoc#installation-configuration-parameters-additional-vsphere_installation-config-parameters-agent[Additional VMware vSphere configuration parameters].
+
+[id="ocp-4-15-agent-baremetal-configuration"]
+==== Additional bare metal configurations on Day 1 with the Agent-based Installer


Suggested change

==== Additional bare metal configurations on Day 1 with the Agent-based Installer

==== Additional bare metal configurations during Agent-based installation

simplified to avoid "day 1" language

bscott-rh · 2024-02-21T20:04:23Z

release_notes/ocp-4-15-release-notes.adoc

+You can now make additional configurations for bare metal platforms while creating the `install-config.yaml` file for an Agent-based Installation.
+These new options include host configuration, network configuration, and baseboard management controller (BMC) details.
+
+These fields are not used during the initial provisioning of the cluster, but they eliminate the need to set the fields as a Day 2 operation.


Suggested change

These fields are not used during the initial provisioning of the cluster, but they eliminate the need to set the fields as a Day 2 operation.

These fields are not used during the initial provisioning of the cluster, but they eliminate the need to set the fields after installation.

openshift-ci · 2024-02-21T20:11:59Z

New changes are detected. LGTM label has been removed.

bscott-rh · 2024-02-21T20:17:33Z

release_notes/ocp-4-15-release-notes.adoc

+[id="ocp-4-15-agent-baremetal-configuration"]
+==== Additional bare metal configurations during Agent-based installation
+
+You can now make additional configurations for the bare metal platform while creating the `install-config.yaml` file for an Agent-based Installation.


This change LGTM.

openshift-ci · 2024-02-21T20:22:57Z

@skopacz1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

skopacz1 · 2024-02-21T20:45:06Z

/label merge-review-needed

JoeAldinger

quick question

JoeAldinger · 2024-02-22T13:42:26Z

release_notes/ocp-4-15-release-notes.adoc

+==== Additional bare metal configurations during Agent-based installation
+
+You can now make additional configurations for the bare metal platform while creating the `install-config.yaml` file for an Agent-based Installation.
+These new options include host configuration, network configuration, and baseboard management controller (BMC) details.


Quick question: are host configuration, network configuration, and BMC all fields in a configuration? If so, I think these would need backticks.

Good question! I meant these terms in a general sense and not to refer to specific fields. And I checked the parameters themselves just now. There is a field for hosts and bmc, but nothing specifically for network.

Since I mean these terms in a general sense and not to refer to any specific fields, can I keep it this way?

I think it is ok as is. Referring to them as fields in the following sentence makes it seem like you are referring to specific fields if that makes sense? Again, no need to change.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2024

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2024

openshift-ci bot assigned bmanzari Feb 21, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024

skopacz1 changed the title ~~OSDOCS-9736: Agent 4.15 feature RNs~~ OSDOCS#9736: Agent 4.15 feature RNs Feb 21, 2024

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 21, 2024

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 21, 2024

bscott-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.15 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 21, 2024

bscott-rh added this to the Planned for 4.15 GA milestone Feb 21, 2024

bscott-rh reviewed Feb 21, 2024

View reviewed changes

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 21, 2024

skopacz1 force-pushed the OSDOCS-9736 branch from 914445c to 930d397 Compare February 21, 2024 20:11

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024

OSDOCS-9736: Agent 4.15 feature RNs

098a0f4

skopacz1 force-pushed the OSDOCS-9736 branch from 930d397 to 098a0f4 Compare February 21, 2024 20:15

bscott-rh reviewed Feb 21, 2024

View reviewed changes

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 21, 2024

JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 22, 2024

JoeAldinger reviewed Feb 22, 2024

View reviewed changes

JoeAldinger merged commit 429ec60 into openshift:enterprise-4.15 Feb 22, 2024

skopacz1 deleted the OSDOCS-9736 branch March 11, 2025 17:16

	==== Additional bare metal configurations on Day 1 with the Agent-based Installer
	==== Additional bare metal configurations during Agent-based installation

	These fields are not used during the initial provisioning of the cluster, but they eliminate the need to set the fields as a Day 2 operation.
	These fields are not used during the initial provisioning of the cluster, but they eliminate the need to set the fields after installation.

OSDOCS#9736: Agent 4.15 feature RNs #71931

OSDOCS#9736: Agent 4.15 feature RNs #71931

Uh oh!

Conversation

skopacz1 commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 20, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skopacz1 commented Feb 20, 2024

Uh oh!

ocpdocs-previewbot commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmanzari commented Feb 21, 2024

Uh oh!

openshift-ci-robot commented Feb 21, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skopacz1 commented Feb 21, 2024

Uh oh!

openshift-ci-robot commented Feb 21, 2024

Uh oh!

skopacz1 commented Feb 21, 2024

Uh oh!

bscott-rh left a comment

Choose a reason for hiding this comment

Uh oh!

bscott-rh Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

bscott-rh Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 21, 2024

Uh oh!

bscott-rh Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 21, 2024

Uh oh!

skopacz1 commented Feb 21, 2024

Uh oh!

JoeAldinger left a comment

Choose a reason for hiding this comment

Uh oh!

JoeAldinger Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

skopacz1 Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

JoeAldinger Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

skopacz1 commented Feb 20, 2024 •

edited

Loading

openshift-ci-robot commented Feb 20, 2024 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Feb 20, 2024 •

edited

Loading

openshift-ci-robot commented Feb 21, 2024 •

edited by openshift-ci bot

Loading