Skip to content

Conversation

nebelsprachen
Copy link

@nebelsprachen nebelsprachen commented Feb 22, 2024

Aligned team: Dev Tools

Version(s):

gitops-docs-1.9

Issue:

RHDEVDOCS#5794

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 22, 2024

🤖 Updated build preview is available at:
https://72015--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37590

remove s
Copy link

@chengfang chengfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nebelsprachen
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 22, 2024
@skopacz1
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 22, 2024
@skopacz1
Copy link
Contributor

Just a heads up that I think you're providing a preview link from another PR, here's the link for this PR: https://72015--docspreview.netlify.app/openshift-gitops/latest/understanding_openshift_gitops/gathering-gitops-diagnostic-information-for-support

Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise LGTM!

@skopacz1
Copy link
Contributor

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 22, 2024
@nebelsprachen
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 22, 2024
@ShaunaDiaz
Copy link
Contributor

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 26, 2024
@ShaunaDiaz ShaunaDiaz merged commit e3fa7e0 into openshift:gitops-docs-1.9 Feb 26, 2024
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitops peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants