OSSM-6347: SM 3.0 Deploying Istio

[rh-tokeefe]

Version(s):
Service Mesh 3.0

Issue:
https://issues.redhat.com/browse/OSSM-6374

Link to docs preview:
https://75094--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html#about-istio-deployment

QE review:

• QE has approved this change.

Additional information:

[openshift-ci-robot]

@rh-tokeefe: This pull request references OSSM-6347 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rh-tokeefe: This pull request references OSSM-6347 which is a valid jira issue.

In response to this:

Version(s): Service Mesh 3.0

Issue: https://issues.redhat.com/browse/OSSM-6374

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ocpdocs-previewbot]

🤖 Wed May 01 16:27:19 - Prow CI generated the docs preview:

https://75094--ocpdocs-pr.netlify.app/
https://75094--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html

[openshift-ci-robot]

@rh-tokeefe: This pull request references OSSM-6347 which is a valid jira issue.

In response to this:

Version(s):
Service Mesh 3.0

Issue:
https://issues.redhat.com/browse/OSSM-6374

Link to docs preview:
https://75094--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html#about-istio-deployment

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fjglira]

I think is not needed to add this information: The Operator deploys Istio to the project you specify. The other fields provide supplementary information and are optional.. In the next section, we already specify that we are going to create the resource in the namespace created before. Regarding the extra fields when you create the resource maybe is better to say this directly in the steps or in a Note in the section. Something like this:

Note: the `istio` resource definition contains supplementary information that is optional to be defined

[rh-tokeefe]

Made minor change here.

[fjglira]

lgtm, I only have small comments

[rh-tokeefe]

@dgn I'm not sure what the prerequisites should be for these tasks. I'm assuming, similar to deploying the control plane in 2.x, it would be similar to this:

• The Red Hat OpenShift Service Mesh Operator must be installed.

• You are logged in to the OpenShift Container Platform web console as cluster-admin.

Is there anything else? I'm not sure if different permissions are needed for creating the project and creating the resource, but I would think not.

Also, for creating the resource, I can add an additional prereq that indicates that the project to which the resource gets deployed must already exist.

Can you think of anything else as far as prereqs?

[dgn]

lgtm, just one comment

[dgn]

@dgn I'm not sure what the prerequisites should be for these tasks. I'm assuming, similar to deploying the control plane in 2.x, it would be similar to this:

* The Red Hat OpenShift Service Mesh Operator must be installed.

* You are logged in to the OpenShift Container Platform web console as cluster-admin.

Those prerequisites are good!

Is there anything else? I'm not sure if different permissions are needed for creating the project and creating the resource, but I would think not.

Also, for creating the resource, I can add an additional prereq that indicates that the project to which the resource gets deployed must already exist.

Don't think that's needed as we explicitly explain how to create the projects

Can you think of anything else as far as prereqs?

Nope, LGTM

[openshift-ci-robot]

@rh-tokeefe: This pull request references OSSM-6347 which is a valid jira issue.

In response to this:

Version(s):
Service Mesh 3.0

Issue:
https://issues.redhat.com/browse/OSSM-6374

Link to docs preview:
https://75094--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html#about-istio-deployment

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gabriel-rh]

n this example, `istio-system' is the name of the project.

Looks like a mismatch

[openshift-ci]

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gabriel-rh]

LGTM