-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Logging 6x - Docs Outline / Planning #76623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1d4b517
to
443ce25
Compare
443ce25
to
1a1b4a3
Compare
1a1b4a3
to
00200c6
Compare
/retest |
00200c6
to
3c9cb59
Compare
bb1c386
to
73c4a2b
Compare
e4d02d1
to
f79cf15
Compare
f79cf15
to
6da32ad
Compare
6da32ad
to
bcd2b50
Compare
bcd2b50
to
aad87d1
Compare
openshiftLabels:: Adds OpenShift-specific labels to log messages. | ||
|
||
// Needs to be validated by engineering for 6.0. | ||
include::modules/logging-audit-log-filtering.adoc[leveloffset=+1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anpingli / @jcantrill : need to know if this can be used for 6.0 & if not what changes are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a #78477 for verification of the CLF content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't changes for kubeAPIAudit. But we need to update the example.
include::modules/logging-audit-log-filtering.adoc[leveloffset=+1] | ||
|
||
// Needs to be validated by engineering for 6.0. | ||
include::modules/logging-content-filter-drop-records.adoc[leveloffset=+1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anpingli / @jcantrill : need to know if this can be used for 6.0 & if not what changes are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a #78477 for verification of the CLF content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can reuse it. there are some bugs. we can summary the status before release.
include::modules/logging-content-filter-drop-records.adoc[leveloffset=+1] | ||
|
||
// Needs to be validated by engineering for 6.0. | ||
include::modules/logging-content-filter-prune-records.adoc[leveloffset=+1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anpingli / @jcantrill : need to know if this can be used for 6.0 & if not what changes are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a #78477 for verification of the CLF content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. we can use it.
* Indicates management state (managed or unmanaged) | ||
// Needs engineering eval re applicability to 6.0 | ||
include::modules/log-forwarding-implementations.adoc[leveloffset=+1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anpingli / @jcantrill : need to know if this can be used for 6.0 & if not what changes are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "this"?.... is it the following verbiage of log6x-clf.adoc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a PR for verification of the CLF content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update in the verification PR.
|
||
[id="log6x-CLF-tuning_{context}"] | ||
== Output tuning | ||
//need to validate how much of this applies to 6.0 & edit as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anpingli / @jcantrill : need to know if this can be used for 6.0 & if not what changes are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tuning largely remains the same though it was moved down to the individual output types since not all things applied to everyone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need the particulars of each for https://issues.redhat.com/browse/OBSDOCS-1169. Are they in the repo somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a Jira: OBSDOCS-1169 for Output tuning section discussion. I believe this discussion can be covered in PR , which is created for verification of the CLF content. So, that is the reason I have covered OBSDOCS-1170 and OBSDOCS-1169 in one PR. Please let me know if you have any other thoughts. Thanks!
modules/logging-6x-v-5x.adoc
Outdated
* **Improved Query Performance:** Loki's indexing and query mechanisms are optimized for speed, enabling faster log retrieval and analysis. | ||
* **Streamlined Configuration:** The removal of Elasticsearch and Fluentd simplify setup and configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's arguable if this streamlines configuration. These are just technologies we no longer offer in 6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplifies? Going from 4 different config options to 1 is certainly...something.
* Indicates management state (managed or unmanaged) | ||
// Needs engineering eval re applicability to 6.0 | ||
include::modules/log-forwarding-implementations.adoc[leveloffset=+1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "this"?.... is it the following verbiage of log6x-clf.adoc
?
|
||
[id="log6x-CLF-tuning_{context}"] | ||
== Output tuning | ||
//need to validate how much of this applies to 6.0 & edit as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tuning largely remains the same though it was moved down to the individual output types since not all things applied to everyone
aad87d1
to
ca79a62
Compare
ca79a62
to
aef31f5
Compare
@libander: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hello Libby, I want to add a comment only about the scheleton and in the code I will put some notes about my findings but as you commented, the priority is that it is well organized.
In the latest versions, they are under Performance and reliability. From my perspective I think of two options.
These points may have been taken into consideration but I preferred to leave them reflected here. I will update and confirm that the review is progressing. Thank you very much for your hard work on the documentation |
/assign @anpingli |
|
||
* You have installed the {clo}. | ||
* You have administrator permissions. | ||
* You have created a `ClusterLogForwarder` custom resource (CR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct. You can create a clusterLogForwarder as the first time with all the needed and not needed to have it previously created.
What it's a requirement is to have create a serviceAccount to be used in the clusterLogForwarder linked to the correct clusterRoles depending on the log types allowed to this serviceAccount to collect.
All the details are already mentioned in the PR https://github.com/openshift/openshift-docs/pull/80384/files exactly here https://github.com/openshift/openshift-docs/pull/80384/files#diff-7312d97cd1d4f7bf7f053f75108d26c4898afe1c9442033332be3b09358f75b5 and here https://github.com/openshift/openshift-docs/pull/80384/files#diff-8a01457b83c79be59c3ecdcc18d761f057790cab1de118070de9608994e11bf2
|
||
= Using the `oc explain` command | ||
|
||
The `oc explain` command is an essential tool in the OpenShift Command-Line Interface (CLI) that provides detailed descriptions of the fields within Kubernetes resources, including Custom Resources (CRs) introduced by Operators. This command is invaluable for administrators and developers who are configuring or troubleshooting resources in an OpenShift cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be useful an example in this section, for example, how to review the outputs and options supported for an specific output. This should be so much helpful as the most of the people doesn't know how to run it or what they need to write
oc explain <API>.spec....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oc explain lokistacks.loki.grafana.com
oc explain recordingrules.loki.grafana.com
oc explain rulerconfigs.loki.grafana.com
oc explain alertingrules.loki.grafana.com
oc explain lokistacks.loki.grafana.com.spec
oc explain lokistacks.loki.grafana.com.spec.storage
oc explain lokistacks.loki.grafana.com.spec.storage.schemas.FIELDS
oc explain lokistacks.loki.grafana.com.spec.size
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
/close |
@libander: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.16+
Issue: https://issues.redhat.com/browse/OBSDOCS-1099
Link to docs previews:
https://76623--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-about.html
https://76623--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-clf.html
https://76623--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-loki.html
https://76623--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-start.html
Additional information: Not intended to merge, this PR is for planning & collaboration.