Skip to content

Conversation

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2024
@libander libander force-pushed the Logging-6.0-PoC branch 2 times, most recently from 1d4b517 to 443ce25 Compare May 29, 2024 12:22
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2024
@libander
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 13, 2024
@libander libander force-pushed the Logging-6.0-PoC branch 4 times, most recently from bb1c386 to 73c4a2b Compare June 26, 2024 09:06
@libander libander changed the title Logging 6x - POC WIP Logging 6x - Docs Outline / Planning Jun 26, 2024
@libander libander force-pushed the Logging-6.0-PoC branch 2 times, most recently from e4d02d1 to f79cf15 Compare June 26, 2024 09:22
@libander
Copy link
Contributor Author

@r2d2rnd

openshiftLabels:: Adds OpenShift-specific labels to log messages.

// Needs to be validated by engineering for 6.0.
include::modules/logging-audit-log-filtering.adoc[leveloffset=+1]
Copy link
Contributor Author

@libander libander Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anpingli / @jcantrill : need to know if this can be used for 6.0 & if not what changes are needed.

https://github.com/openshift/openshift-docs/blob/enterprise-4.16/modules/logging-audit-log-filtering.adoc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a #78477 for verification of the CLF content.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't changes for kubeAPIAudit. But we need to update the example.

include::modules/logging-audit-log-filtering.adoc[leveloffset=+1]

// Needs to be validated by engineering for 6.0.
include::modules/logging-content-filter-drop-records.adoc[leveloffset=+1]
Copy link
Contributor Author

@libander libander Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a #78477 for verification of the CLF content.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can reuse it. there are some bugs. we can summary the status before release.

include::modules/logging-content-filter-drop-records.adoc[leveloffset=+1]

// Needs to be validated by engineering for 6.0.
include::modules/logging-content-filter-prune-records.adoc[leveloffset=+1]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anpingli / @jcantrill : need to know if this can be used for 6.0 & if not what changes are needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a #78477 for verification of the CLF content.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. we can use it.

* Indicates management state (managed or unmanaged)
// Needs engineering eval re applicability to 6.0
include::modules/log-forwarding-implementations.adoc[leveloffset=+1]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anpingli / @jcantrill : need to know if this can be used for 6.0 & if not what changes are needed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "this"?.... is it the following verbiage of log6x-clf.adoc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a PR for verification of the CLF content.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update in the verification PR.


[id="log6x-CLF-tuning_{context}"]
== Output tuning
//need to validate how much of this applies to 6.0 & edit as needed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anpingli / @jcantrill : need to know if this can be used for 6.0 & if not what changes are needed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuning largely remains the same though it was moved down to the individual output types since not all things applied to everyone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need the particulars of each for https://issues.redhat.com/browse/OBSDOCS-1169. Are they in the repo somewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a Jira: OBSDOCS-1169 for Output tuning section discussion. I believe this discussion can be covered in PR , which is created for verification of the CLF content. So, that is the reason I have covered OBSDOCS-1170 and OBSDOCS-1169 in one PR. Please let me know if you have any other thoughts. Thanks!

Cc @jcantrill @anpingli @libander @briandooley

* **Improved Query Performance:** Loki's indexing and query mechanisms are optimized for speed, enabling faster log retrieval and analysis.
* **Streamlined Configuration:** The removal of Elasticsearch and Fluentd simplify setup and configuration.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's arguable if this streamlines configuration. These are just technologies we no longer offer in 6.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifies? Going from 4 different config options to 1 is certainly...something.

* Indicates management state (managed or unmanaged)
// Needs engineering eval re applicability to 6.0
include::modules/log-forwarding-implementations.adoc[leveloffset=+1]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "this"?.... is it the following verbiage of log6x-clf.adoc?


[id="log6x-CLF-tuning_{context}"]
== Output tuning
//need to validate how much of this applies to 6.0 & edit as needed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuning largely remains the same though it was moved down to the individual output types since not all things applied to everyone

Copy link

openshift-ci bot commented Jun 28, 2024

@libander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-portal aef31f5 link true /test validate-portal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@acandelp
Copy link

acandelp commented Jul 1, 2024

Hello Libby,

I want to add a comment only about the scheleton and in the code I will put some notes about my findings but as you commented, the priority is that it is well organized.

  • The following sections are under Performance and reliability tuning and also under Configuring log Forwarding.:
    Filtering logs by content
    Filtering logs by metadata

In the latest versions, they are under Performance and reliability.

From my perspective I think of two options.

  1. Leave it as in the latest versions and also add Forwarding application logs from specific projects and Forwarding application logs from specific pods sections or,

  2. Leave it under Configuring log Forwarding and create a new content inside this section adding these filters and Forwarding application logs from specific projects and Forwarding application logs from specific pods sections (Don't forget to add how to send the logs to an external third-party).

  • Configuring LokiStack storage section is fine but inside Log Storage section we found a section called Configuring the LokiStack log store and installing log storage. Maybe for the customer should be easy to have only one section with different contents that matches all the information from the three points.

These points may have been taken into consideration but I preferred to leave them reflected here. I will update and confirm that the review is progressing.

Thank you very much for your hard work on the documentation

@anpingli
Copy link

/assign @anpingli


* You have installed the {clo}.
* You have administrator permissions.
* You have created a `ClusterLogForwarder` custom resource (CR).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. You can create a clusterLogForwarder as the first time with all the needed and not needed to have it previously created.

What it's a requirement is to have create a serviceAccount to be used in the clusterLogForwarder linked to the correct clusterRoles depending on the log types allowed to this serviceAccount to collect.

All the details are already mentioned in the PR https://github.com/openshift/openshift-docs/pull/80384/files exactly here https://github.com/openshift/openshift-docs/pull/80384/files#diff-7312d97cd1d4f7bf7f053f75108d26c4898afe1c9442033332be3b09358f75b5 and here https://github.com/openshift/openshift-docs/pull/80384/files#diff-8a01457b83c79be59c3ecdcc18d761f057790cab1de118070de9608994e11bf2

@libander


= Using the `oc explain` command

The `oc explain` command is an essential tool in the OpenShift Command-Line Interface (CLI) that provides detailed descriptions of the fields within Kubernetes resources, including Custom Resources (CRs) introduced by Operators. This command is invaluable for administrators and developers who are configuring or troubleshooting resources in an OpenShift cluster.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be useful an example in this section, for example, how to review the outputs and options supported for an specific output. This should be so much helpful as the most of the people doesn't know how to run it or what they need to write

oc explain <API>.spec....

@libander

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oc explain lokistacks.loki.grafana.com
oc explain recordingrules.loki.grafana.com
oc explain rulerconfigs.loki.grafana.com
oc explain alertingrules.loki.grafana.com
oc explain lokistacks.loki.grafana.com.spec
oc explain lokistacks.loki.grafana.com.spec.storage
oc explain lokistacks.loki.grafana.com.spec.storage.schemas.FIELDS
oc explain lokistacks.loki.grafana.com.spec.size

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 24, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 25, 2024
@libander
Copy link
Contributor Author

/close

Copy link

openshift-ci bot commented Dec 25, 2024

@libander: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants