Skip to content

Conversation

snarayan-redhat
Copy link
Contributor

@snarayan-redhat snarayan-redhat commented Jun 4, 2024

Version(s): 4.14

Issue: https://issues.redhat.com/browse/OSDOCS-10586

Link to docs preview: https://76852--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes.html#ocp-4-14-oci

Review:

  • QE has approved this change.
  • PM has approved this change.
  • SME has approved this change.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 4, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 4, 2024

🤖 Fri Jun 07 09:38:57 - Prow CI generated the docs preview:

https://76852--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes.html

@makentenza
Copy link
Contributor

LGTM

Copy link
Contributor

@makentenza makentenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhanss
Copy link

mhanss commented Jun 5, 2024

LGTM

@adriengentil
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
@yobshans
Copy link

yobshans commented Jun 6, 2024

/lgtm

Copy link

openshift-ci bot commented Jun 6, 2024

@yobshans: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

For more information, see xref:../storage/container_storage_interface/persistent-storage-csi-azure-file.adoc#persistent-storage-csi-azure-file-nfs_persistent-storage-csi-azure-file[NFS support].

[id="ocp-4-14-oci"]
=== Oracle(R) Cloud Infrastructure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then again, I see that #76850 is removing the TP, so all references to dev preview should be removed for this feature? I ask as the TP tables have an entry that needs updating.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
Copy link

openshift-ci bot commented Jun 7, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

@makentenza makentenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snarayan-redhat snarayan-redhat force-pushed the OCPBUGS-10586_removetp_414 branch 2 times, most recently from d23224c to b64a2e3 Compare June 7, 2024 09:30
@snarayan-redhat snarayan-redhat force-pushed the OCPBUGS-10586_removetp_414 branch from b64a2e3 to b7b84fc Compare June 7, 2024 09:33
Copy link

openshift-ci bot commented Jun 7, 2024

@snarayan-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor

dfitzmau commented Jun 7, 2024

LGTM

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 7, 2024
@snarayan-redhat snarayan-redhat merged commit 36d9c10 into openshift:enterprise-4.14 Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants