Skip to content

OSDOCS-10142 OCPSTRAT-1114: Include the version of the oc binary used… #77129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

OSDOCS-10142 OCPSTRAT-1114: Include the version of the oc binary used… #77129

merged 1 commit into from
Jun 12, 2024

Conversation

cbippley
Copy link
Contributor

@cbippley cbippley commented Jun 6, 2024 •
edited
Loading

…, and the logs generated by the command into the must-gather directory

Version(s): 4.16

Issue: OSDOCS-10142

Link to docs preview: Preview

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2024 •
edited by openshift-ci bot
Loading

@cbippley: This pull request references OSDOCS-10142 which is a valid jira issue.

This pull request references OCPSTRAT-1114 which is a valid jira issue.

In response to this:

…, and the logs generated by the command into the must-gather directory

Version(s): 4.16

Issue: OSDOCS-10142

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 6, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 6, 2024 •
edited
Loading

🤖 Tue Jun 11 21:13:17 - Prow CI generated the docs preview:

https://77129--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html

@cbippley
Copy link
Contributor Author

cbippley commented Jun 6, 2024

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2024 •
edited by openshift-ci bot
Loading

@cbippley: This pull request references OSDOCS-10142 which is a valid jira issue.

This pull request references OCPSTRAT-1114 which is a valid jira issue.

In response to this:

…, and the logs generated by the command into the must-gather directory

Version(s): 4.16

Issue: OSDOCS-10142

Link to docs preview: Preview

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bergerhoffer
bergerhoffer reviewed Jun 6, 2024
View reviewed changes
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2024
@ingvagabund
Copy link
Member

lgtm

@cbippley
Copy link
Contributor Author

@wsun1 Could you PTAL?

@zhouying7780
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@wsun1
Copy link

wsun1 commented Jun 11, 2024

/lgtm

@kasturinarra
Copy link

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 11, 2024 •
edited by openshift-ci bot
Loading

@cbippley: This pull request references OSDOCS-10142 which is a valid jira issue.

This pull request references OCPSTRAT-1114 which is a valid jira issue.

In response to this:

…, and the logs generated by the command into the must-gather directory

Version(s): 4.16

Issue: OSDOCS-10142

Link to docs preview: Preview

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cbippley
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 11, 2024
@maxwelldb maxwelldb added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 11, 2024
@maxwelldb maxwelldb self-requested a review June 11, 2024 15:08
maxwelldb
maxwelldb reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and suggestions. There are few minor tweaks to make here before merge.

@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 11, 2024
@maxwelldb maxwelldb added this to the Planned for 4.16 GA milestone Jun 11, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 11, 2024

New changes are detected. LGTM label has been removed.

@cbippley
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 11, 2024
ShaunaDiaz
ShaunaDiaz reviewed Jun 11, 2024
View reviewed changes
@ShaunaDiaz
Copy link
Contributor

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 11, 2024
@cbippley
OSDOCS-10142 OCPSTRAT-1114: Include the version of the oc binary used…
ca38722 
…, and the logs generated by the command into the must-gather directory
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 11, 2024

@cbippley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cbippley
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 11, 2024
@ShaunaDiaz
Copy link
Contributor

/remove-label merge-review-needed

@ShaunaDiaz ShaunaDiaz merged commit f2ac208 into openshift:enterprise-4.16 Jun 12, 2024
@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@maxwelldb maxwelldb maxwelldb left review comments

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

Assignees

@wsun1 wsun1

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

Labels

branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.16 GA

Development

Successfully merging this pull request may close these issues.

10 participants

@cbippley @openshift-ci-robot @ocpdocs-previewbot @ingvagabund @zhouying7780 @wsun1 @kasturinarra @ShaunaDiaz @bergerhoffer @maxwelldb