Skip to content

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Jun 10, 2024

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 10, 2024

Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anpingli
Copy link

/lgtm

@shreyasiddhartha
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 10, 2024
@JoeAldinger JoeAldinger added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 10, 2024
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JoeAldinger JoeAldinger added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 10, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@JoeAldinger JoeAldinger removed their assignment Jun 10, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
Copy link

openshift-ci bot commented Jun 12, 2024

New changes are detected. LGTM label has been removed.

@shreyasiddhartha
Copy link
Contributor Author

/lgtm

Made the same changes matching your comments in the 5.8.8 PR.

Copy link

openshift-ci bot commented Jun 12, 2024

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@libander
Copy link
Contributor

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 12, 2024
@stevsmit stevsmit added branch/enterprise-4.12 merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 branch/enterprise-4.14 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 12, 2024
@stevsmit stevsmit merged commit 2affa73 into openshift:enterprise-4.14 Jun 12, 2024
@stevsmit
Copy link
Member

/cherry-pick enterprise-4.13

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot

@stevsmit: new pull request created: #77394

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #77395

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants