Skip to content

Conversation

sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Jun 10, 2024

Version(s):
4.16

Issue:
OSDOCS-10135

Link to docs preview:

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 10, 2024

🤖 Wed Jun 19 18:42:56 - Prow CI generated the docs preview:

https://77260--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html

@sr1kar99 sr1kar99 force-pushed the release-notes-4-16-multi-arch branch 2 times, most recently from 2f88eec to d47539e Compare June 10, 2024 18:26
Copy link
Member

@aleskandro aleskandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

(lgtm for the Multiarch Tuning Operator)

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 11, 2024
@sr1kar99 sr1kar99 force-pushed the release-notes-4-16-multi-arch branch 3 times, most recently from d722874 to 3ec9cf8 Compare June 12, 2024 15:16
@sr1kar99
Copy link
Contributor Author

/retest

1 similar comment
@sr1kar99
Copy link
Contributor Author

/retest

@sr1kar99
Copy link
Contributor Author

@jeffdyoung
Could you please review this PR?
Thanks!

@sr1kar99 sr1kar99 force-pushed the release-notes-4-16-multi-arch branch from 3ec9cf8 to 600ca7f Compare June 14, 2024 09:54
@sr1kar99
Copy link
Contributor Author

Hi @lwan-wanglin

Could you please review this PR when you get a chance?
Thanks!

@sr1kar99 sr1kar99 force-pushed the release-notes-4-16-multi-arch branch from 600ca7f to 91fd948 Compare June 14, 2024 15:45
@jeffdyoung
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
@sr1kar99
Copy link
Contributor Author

@zniu1011 @lwan-wanglin
Could you please review this PR when you get a chance?
Thanks!

@lwan-wanglin
Copy link

lgtm for the Multiarch Tuning Operator and Agent-based installation with multi payload part. for feature adding 64-bit x86 compute machines to a cluster with 64-bit ARM control plane machines, I don't take this part test.

@sr1kar99
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 17, 2024
@aleskandro
Copy link
Member

/label qe-approved

@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.16 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 17, 2024
@mburke5678 mburke5678 added this to the Planned for 4.16 GA milestone Jun 17, 2024
@mburke5678
Copy link
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2024
@sr1kar99 sr1kar99 force-pushed the release-notes-4-16-multi-arch branch from 91fd948 to de97cf9 Compare June 17, 2024 18:15
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2024
@lwan-wanglin
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@sr1kar99 sr1kar99 force-pushed the release-notes-4-16-multi-arch branch from de97cf9 to e171df3 Compare June 19, 2024 04:44
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024
Copy link

openshift-ci bot commented Jun 19, 2024

New changes are detected. LGTM label has been removed.

@sr1kar99 sr1kar99 force-pushed the release-notes-4-16-multi-arch branch from e171df3 to 2281dc6 Compare June 19, 2024 05:49
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2024
@sr1kar99
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 19, 2024
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 19, 2024
@mburke5678
Copy link
Contributor

@sr1kar99 If you can fix the merge conflict, let me know and I can merge

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2024
@sr1kar99 sr1kar99 force-pushed the release-notes-4-16-multi-arch branch from 2281dc6 to 54047db Compare June 19, 2024 18:37
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2024
Copy link

openshift-ci bot commented Jun 19, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 merged commit 699e680 into openshift:enterprise-4.16 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants