Skip to content

Conversation

dhgautam99
Copy link
Contributor

clf.spec.tuning doesn't exist in the product but the correct way of defining the tuning config is clf.spec.outputs.tuning

 $ oc explain clusterlogforwarder.spec.tuning
GROUP:      logging.openshift.io
KIND:       ClusterLogForwarder
VERSION:    v1error: field "tuning" does not exist
 $ oc explain clusterlogforwarder.spec.outputs.tuning
GROUP:      logging.openshift.io
KIND:       ClusterLogForwarder
VERSION:    v1FIELD: tuning <Object>DESCRIPTION:
    Tuning parameters for the output.  Specifying these parameters will alter
    the characteristics of log forwarder which may be different from its
    behavior without the tuning.

Same has been corrected in this PR.

Version(s): RHOCP 4.13, RHOCP 4.14 and RHOCP 4.15

Issue: https://issues.redhat.com/browse/OBSDOCS-1049

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

clf.spec.tuning doesn't exist in the product but the correct way of defining the tuning config is clf.spec.outputs.tuning
~~~
 $ oc explain clusterlogforwarder.spec.tuning
GROUP:      logging.openshift.io
KIND:       ClusterLogForwarder
VERSION:    v1error: field "tuning" does not exist
~~~

~~~
 $ oc explain clusterlogforwarder.spec.outputs.tuning
GROUP:      logging.openshift.io
KIND:       ClusterLogForwarder
VERSION:    v1FIELD: tuning <Object>DESCRIPTION:
    Tuning parameters for the output.  Specifying these parameters will alter
    the characteristics of log forwarder which may be different from its
    behavior without the tuning.
~~~

Same has been corrected in this PR.
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2024
Copy link

openshift-ci bot commented Jun 14, 2024

Hi @dhgautam99. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@libander libander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes entirely to YAML.
/lgtm

@libander
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2024
@libander
Copy link
Contributor

@kabirbhartiRH / @anpingli - Review, please.

Copy link

openshift-ci bot commented Jun 14, 2024

@dhgautam99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@libander
Copy link
Contributor

libander commented Aug 6, 2024

@kabirbhartiRH / @anpingli - Review, please.

@dhgautam99 - the OCP repo won't accept a merge without QE review.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 5, 2024
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jan 5, 2025
Copy link

openshift-ci bot commented Jan 5, 2025

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants