-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Tuning log payloads and delivery section || Corrected tuning implementation YAML #77521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clf.spec.tuning doesn't exist in the product but the correct way of defining the tuning config is clf.spec.outputs.tuning ~~~ $ oc explain clusterlogforwarder.spec.tuning GROUP: logging.openshift.io KIND: ClusterLogForwarder VERSION: v1error: field "tuning" does not exist ~~~ ~~~ $ oc explain clusterlogforwarder.spec.outputs.tuning GROUP: logging.openshift.io KIND: ClusterLogForwarder VERSION: v1FIELD: tuning <Object>DESCRIPTION: Tuning parameters for the output. Specifying these parameters will alter the characteristics of log forwarder which may be different from its behavior without the tuning. ~~~ Same has been corrected in this PR.
Hi @dhgautam99. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes entirely to YAML.
/lgtm
/ok-to-test |
@kabirbhartiRH / @anpingli - Review, please. |
@dhgautam99: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@kabirbhartiRH / @anpingli - Review, please. @dhgautam99 - the OCP repo won't accept a merge without QE review. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
clf.spec.tuning doesn't exist in the product but the correct way of defining the tuning config is clf.spec.outputs.tuning
Same has been corrected in this PR.
Version(s): RHOCP 4.13, RHOCP 4.14 and RHOCP 4.15
Issue: https://issues.redhat.com/browse/OBSDOCS-1049
Link to docs preview:
QE review:
Additional information: