Skip to content

RHDEVDOCS-6101: DOC: Add a flag on controllers to configure resyncPeriod in openshift-pipelines #79107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2024
Merged

RHDEVDOCS-6101: DOC: Add a flag on controllers to configure resyncPeriod in openshift-pipelines #79107

merged 1 commit into from
Aug 6, 2024

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Jul 19, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references RHDEVDOCS-6101 which is a valid jira issue.

In response to this:

Version(s): pipelines-docs-1.16

Issue: RHDEVDOCS-6101

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 19, 2024 •
edited
Loading

🤖 Tue Aug 06 07:40:57 - Prow CI generated the docs preview:

https://79107--ocpdocs-pr.netlify.app/openshift-pipelines/latest/install_config/customizing-configurations-in-the-tektonconfig-cr.html

@eromanova97
Copy link
Contributor Author

@mramendi here is the PR I created, tagging you in this for quick review. Thank you!

mramendi
mramendi reviewed Jul 19, 2024
View reviewed changes
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references RHDEVDOCS-6101 which is a valid jira issue.

In response to this:

Version(s): pipelines-docs-1.16

Issue: RHDEVDOCS-6101

Link to docs preview: https://79107--ocpdocs-pr.netlify.app/openshift-pipelines/latest/install_config/customizing-configurations-in-the-tektonconfig-cr.html#op-setting-resync-period_customizing-configurations-in-the-tektonconfig-cr

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 changed the title [WIP] RHDEVDOCS-6101: DOC: Add a flag on controllers to configure resyncPeriod in openshift-pipelines RHDEVDOCS-6101: DOC: Add a flag on controllers to configure resyncPeriod in openshift-pipelines Jul 22, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references RHDEVDOCS-6101 which is a valid jira issue.

In response to this:

Version(s): pipelines-docs-1.16

Issue: RHDEVDOCS-6101

Link to docs preview: https://79107--ocpdocs-pr.netlify.app/openshift-pipelines/latest/install_config/customizing-configurations-in-the-tektonconfig-cr.html#op-setting-resync-period_customizing-configurations-in-the-tektonconfig-cr

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 5, 2024
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 5, 2024
@skopacz1 skopacz1 added this to the Continuous Release milestone Aug 5, 2024
skopacz1
skopacz1 reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments and suggestions, otherwise looks good to me!

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 6, 2024

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 6, 2024
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 6, 2024
skopacz1
skopacz1 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM

@skopacz1 skopacz1 merged commit f55473b into openshift:pipelines-docs-main Aug 6, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented Aug 6, 2024

/cherrypick pipelines-docs-1.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 6, 2024
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #80079

In response to this:

/cherrypick pipelines-docs-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 6, 2024
@eromanova97 eromanova97 deleted the RHDEVDOCS-6101 branch August 7, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skopacz1 skopacz1 skopacz1 approved these changes

+3 more reviewers

@mramendi mramendi mramendi left review comments

@vdemeester vdemeester vdemeester approved these changes

@ppitonak ppitonak ppitonak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @skopacz1 @openshift-cherrypick-robot @vdemeester @ppitonak @mramendi